Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make filling of contact_information, location_information, and social_information optional. #25

Open
algomaster99 opened this issue Jul 16, 2020 · 3 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@algomaster99
Copy link
Member

The app currently doesn't load if the contact_information, location_information, and social_information are registered for MaintainerGroup.
404

It shows 404 above but it hasn't been handled correctly and the app just shows a loader sign. This information is used here.
Screenshot from 2020-07-17 01-09-47

But if these entities aren't registered, we can show "-" to indicate that it doesn't exist. No need to stop the whole from rendering.

@algomaster99 algomaster99 added the good first issue Good for newcomers label Jul 16, 2020
@MihirSachdeva
Copy link
Member

I would like to work on this issue 😄

@algomaster99
Copy link
Member Author

@MihirSachdeva all yours 💯

@pradumangoyal
Copy link
Member

Any updates on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants