Fixed overflow of pomodoro screen on landscape #125 #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Sanat-Jha Please solve merge conflicts. I'll review this then. |
|
@Akshit517 merge conflicts resolved. please review. |
Akshit517
requested changes
Jan 9, 2025
There was a problem hiding this comment.
@Sanat-Jha Could you make it more responsive? While you've resolved the overflow issue using SingleChildScrollView, consider using LayoutBuilder with breakpoints to ensure the countdown timer is fully visible in landscape mode or on devices with larger widths.
Sanat-Jha
force-pushed
the
pomodoro-screen-landscape-overflow
branch
from
95cf22e to
8298b01
Compare
|
@Akshit517 Used layout builder for displaying on landscape . Please review
|
Akshit517
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #125
Type of Change
Put
xinside the square bracket to specify what type of change your PR is:Description of Change
Made the pomodoro screen scrollable for screens with small height which was facing overflow.