Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning delete #77

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

asutosh29
Copy link

Related Issue
Closes #22

Type of Change
Put x inside the square bracket to specify what type of change your PR is:

[x] New Feature
Bug Fix
Code Refactor
Documentation Update
Other (please specify):

Description of Change
Ask for confirmation before deleting a password

Implementation Details
Take input the name of the site and again prompt asking for confirmation. If the input is Y or y then password is deleted, other wise a message is shown "No changes made!"

Demo
if Yes
image
if No
image

@fillingtothemomo
Copy link
Collaborator

@asutosh29 please resolve merge conflicts and commit, the changes look good to me, I'll merge it once conflicts are resolved

@asutosh29
Copy link
Author

I am away from home, will fix it in 2 hours

@fillingtothemomo
Copy link
Collaborator

@asutosh29 please pull new changes again and resolve conflicts. Apologies for the messy commit history, we had to revert some changes.

@fillingtothemomo fillingtothemomo marked this pull request as draft January 3, 2025 19:09
@asutosh29 asutosh29 marked this pull request as ready for review January 4, 2025 22:44
@asutosh29
Copy link
Author

Resolved the conflicts

  1. Menu bar option after logging, in was updated
  2. Removed the older Menu bar options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add confirmation before deleting a password
2 participants