Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve model for thickeners #1304

Merged
merged 14 commits into from
Dec 19, 2023
Merged

Improve model for thickeners #1304

merged 14 commits into from
Dec 19, 2023

Conversation

andrewlee94
Copy link
Member

Fixes None

Summary/Motivation:

This PR adds an improved, predictive model for thickener/clarifiers which replaces the previous thickener model.

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@andrewlee94 andrewlee94 self-assigned this Dec 13, 2023
@andrewlee94 andrewlee94 added enhancement New feature or request Priority:Normal Normal Priority Issue or PR unit models Issues dealing with the unit model libraries backward-compat Affects backward compatibility PrOMMiS Issues related to PrOMMiS activities labels Dec 13, 2023
Copy link
Contributor

@MarcusHolly MarcusHolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a few small comments

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6352629) 77.39% compared to head (0a8e039) 77.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1304      +/-   ##
==========================================
+ Coverage   77.39%   77.40%   +0.01%     
==========================================
  Files         390      390              
  Lines       63547    63631      +84     
  Branches    11699    11702       +3     
==========================================
+ Hits        49182    49255      +73     
- Misses      11832    11839       +7     
- Partials     2533     2537       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ksbeattie ksbeattie removed the request for review from eslickj December 14, 2023 19:29
Copy link
Contributor

@agarciadiego agarciadiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewlee94 andrewlee94 enabled auto-merge (squash) December 19, 2023 15:48
@andrewlee94 andrewlee94 merged commit de15ec0 into IDAES:main Dec 19, 2023
37 checks passed
@andrewlee94 andrewlee94 deleted the thickener3 branch December 19, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backward-compat Affects backward compatibility enhancement New feature or request Priority:Normal Normal Priority Issue or PR PrOMMiS Issues related to PrOMMiS activities unit models Issues dealing with the unit model libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants