Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing errors due to bound checking in nl writer #1293

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

andrewlee94
Copy link
Member

Related to #1292

Summary/Motivation:

Pyomo 6.7.0 added checks for fixed variables which violate bounds which caused a number of our tests to fail (about half were deliberate violations in the diagnostics tools for testing, but the rest were real).

Changes proposed in this PR:

  • Updated tests to remove bound violations

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@andrewlee94 andrewlee94 self-assigned this Nov 28, 2023
@andrewlee94 andrewlee94 added bug Something isn't working Priority:High High Priority Issue or PR testing Issues dealing with testing of code backward-compat Affects backward compatibility pyomo labels Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (446ff39) 77.41% compared to head (ca87f29) 77.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1293      +/-   ##
==========================================
- Coverage   77.41%   77.40%   -0.01%     
==========================================
  Files         390      390              
  Lines       63402    63402              
  Branches    11658    11658              
==========================================
- Hits        49083    49077       -6     
- Misses      11792    11797       +5     
- Partials     2527     2528       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jsiirola jsiirola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, but is there a plan to restore the tests that trigger the initialization error?

@andrewlee94
Copy link
Member Author

@jsiirola Not at this point, as the model.initialize() API is deprecated.

@andrewlee94 andrewlee94 enabled auto-merge (squash) November 28, 2023 19:41
@andrewlee94 andrewlee94 merged commit 41bb3c9 into IDAES:main Nov 28, 2023
50 checks passed
@andrewlee94 andrewlee94 deleted the pyomo_6_7_fixes branch November 28, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backward-compat Affects backward compatibility bug Something isn't working Priority:High High Priority Issue or PR pyomo testing Issues dealing with testing of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants