Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MAGICC variables #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

phackstock
Copy link
Contributor

As MAGICC becomes more integrated into a number of projects I figured it might be a good idea to add all MAGICC variables to this repo.

@phackstock phackstock self-assigned this Aug 29, 2023
Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tag-lists for the percentiles and the species, see https://github.com/IAMconsortium/common-definitions/blob/main/definitions/variable/emissions/tag_tier3_species.yaml (but you cannot directly re-use because of different units).

@@ -0,0 +1,1376 @@
- AR6 climate diagnostics|Atmospheric Concentrations|CH4|MAGICCv7.5.3|10.0th Percentile:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with the variable-notation guidelines.

Suggested change
- AR6 climate diagnostics|Atmospheric Concentrations|CH4|MAGICCv7.5.3|10.0th Percentile:
- AR6 Climate Diagnostics|Atmospheric Concentrations|CH4|MAGICCv7.5.3|10.0th Percentile:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR still meant to be merged?

And if so, I suppose this capitalisation be changed directly in iiasa/climate-assessment?
I don't have any capacity for this right now (it's a small update, but updating the test-data is a bit of a pain, and just need to do a quick check to make sure it wouldn't break anything in notebooks or other scripts, and backward-compatibility).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I wouldn't say it's super urgent. MAGICC variables are currently added after the variable validation so this PR is good to have for sure, but not essential right now.

@danielhuppmann
Copy link
Member

FWIW, I think it might even be preferable to keep these variables in a separate repo directly attached to the climate-processing workflows - this way, the output of climate-processing is "together" with the expected variables. For validation, the variables could still be imported to a project-workflow repo (if necessary).

@phackstock
Copy link
Contributor Author

@danielhuppmann, I like the idea. We could and probably should encourage this for all future post-processing steps. Each step should come with it's own set of defined output variables.

@jkikstra
Copy link
Contributor

Okay sounds good, just let me know if/when you need anything from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants