Remove deprecated functions #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleysmithTTD
commented
Dec 13, 2024
| @@ -22,7 +22,7 @@ export class EUID extends SdkBase { | |||
| ); | |||
| return EUID.cookieName; | |||
| } | |||
| static get EuidDetails(): ProductDetails { | |||
| private static get EuidDetails(): ProductDetails { | |||
| return productDetails; | |||
| } | |||
There was a problem hiding this comment.
this should be private to match the corresponding function in uid2Sdk.ts
ashleysmithTTD
commented
Dec 13, 2024
| @@ -528,14 +530,14 @@ describe('Store config UID2', () => { | |||
| const cookie = getConfigCookie(); | |||
| expect(cookie).toBeInstanceOf(Object); | |||
| expect(cookie).toHaveProperty('cookieDomain'); | |||
| const storageConfig = loadConfig(productDetails); | |||
| const storageConfig = getConfigStorage(); | |||
There was a problem hiding this comment.
This should have been getConfigStorage() all along. loadConfig can return the config from local storage or the cookie, but we are testing that it is not in local storage
ashleysmithTTD
commented
Dec 13, 2024
| localStorageKey: 'EUID-sdk-identity', | ||
| cookieName: '__euid', | ||
| }; | ||
|
|
There was a problem hiding this comment.
We could possibly import these product details from euidSdk.ts and same for the uid2 product details from uid2Sdk.ts instead of redefining them in multiple places - but the point is that productDetails is private and if we exported them to import in these test files, would that make them public now?
ssundahlTTD
approved these changes
Dec 17, 2024
ashleysmithTTD
changed the title
ssundahlTTD
approved these changes
Dec 17, 2024
ashleysmithTTD
deleted the
ans-UID2-4079-address-deprecated-methods-and-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.