add tomestone flag bit into OptOutEntry to avoid major changes #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -131,16 +154,19 @@ public int hashCode() { | |||
| return (int) (timestamp + Arrays.hashCode(identityHash) + Arrays.hashCode(advertisingId)); | |||
| } | |||
|
|
|||
| private static byte calcMetadata(byte[] advertisingId) { | |||
There was a problem hiding this comment.
Do we need to leave the old function in for backward compatibility?
| public OptOutEntry(byte[] identityHash, byte[] advertisingId, long ts) { | ||
| assert identityHash.length == OptOutConst.Sha256Bytes; | ||
| assert advertisingId.length == OptOutConst.Sha256Bytes || advertisingId.length == OptOutConst.Sha256Bytes + 1; | ||
| // assert ts >= 0; | ||
| this.identityHash = identityHash; | ||
| this.advertisingId = advertisingId; | ||
| this.timestamp = ts; | ||
| this.isTombstone = false; |
There was a problem hiding this comment.
Can you call the constructor below instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use 6th bit (from low) in the metadata byte to indicate user opt-in. This keeps all the data pipeline intact as we are not adding new record types. Only change required from consumer is to check that bit from the opt out record found.