Elements and Common Refactoring Fixed #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmanko
changed the title
Pprado23
approved these changes
Aug 10, 2024
input/cql/HIVIND24Logic.cql
Outdated
There was a problem hiding this comment.
will combine(HIE.patientGroups.code), ':') not work? I'm concerned about flatten.
There was a problem hiding this comment.
Yeah it should work - i need to take a look why it was giving me a nested list given the definition of the functions
ibacher
approved these changes
Aug 10, 2024
input/cql/HIVCommon.cql
Outdated
Comment on lines
274
to
284
| define function ExtractMedicationCode(choice Choice<FHIR.CodeableConcept, FHIR.Reference>): | ||
| case | ||
| when choice is FHIR.CodeableConcept then | ||
| choice as FHIR.CodeableConcept | ||
| when choice is FHIR.Reference then | ||
| First([Medication] M | ||
| where M.id = Last(Split(choice.reference, '/')) | ||
| return M.code as FHIR.CodeableConcept) | ||
| else | ||
| Message(null as FHIR.CodeableConcept, true, '1', 'Error', 'Cannot compute a medication code') // TODO: I'm sure that this is supported somehow? | ||
| end |
There was a problem hiding this comment.
nit: this element uses both spaces and tabs, which means the indentations renders inconsistently.
| @@ -7,7 +7,7 @@ Usage: #definition | |||
| * meta.profile[+] = "http://hl7.org/fhir/uv/crmi/StructureDefinition/crmi-publishablelibrary" | |||
| * meta.profile[+] = "http://hl7.org/fhir/uv/cql/StructureDefinition/cql-library" | |||
| * meta.profile[+] = "http://hl7.org/fhir/uv/cql/StructureDefinition/cql-module" | |||
| * url = "http://smart.who.int/hivIndicator/Library/HIVIndicatorElements" | |||
| * url = "http://smart.who.int/HIVIndicator/Library/HIVIndicatorElements" | |||
There was a problem hiding this comment.
Shouldn't this be /hiv/HIVIndicator (or just /hiv/Library)?
input/cql/HIVB9DTLogic.cql
Outdated
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| @DecisionID: HIV.B9.DT | |||
| @DecisionID: HIV.B9.DT Logic | |||
There was a problem hiding this comment.
"Logic" is the name of the library, but not the DecisionID (reviewing the SOP it should be @DecisionID: HIV.B9.DT.HIV Re-testing Recommendations
Suggested change
| @DecisionID: HIV.B9.DT Logic | |
| @DecisionID: HIV.B9.DT.HIV Re-testing Recommendations |
There was a problem hiding this comment.
We could put:
Library: HIV.B9.DT Logic
At the start for consistency?
pmanko
added a commit
that referenced
this pull request
Aug 18, 2024
* Updated elements names (#36) * Small fix to generated element comments * WSG-90 HIV Indicators Update Updated Common logic as well * Updated naming and fixed some errors (#40) * HIVB9DT (#42) * WSG 97 indicators HIV.IND.28-35 (#41) * Wsg 99 fixed (#45) * IND 44 * IND 45 * Refactoring and updates to IND44 and IND45 * Updated Config file * indicators 37-39 * Fixed IG Builder translation issues * Elements and Common Refactoring Fixed (#46) * Removed erroring include FHIRCommon * Fixed EncounterElements * Elements fixes * Indicator fixes * Validation fixes * Review fixes * Wsg 101 indicators 46 55 (#50) * indicators 46-47 * HIVIND 46 - 52 updated * indicators 46-55 * Implement B9 DT and B2 DT (#47) * Start decision table logic for HIVB9DT; format HIVB7DTLogic * Two HIV B decision tables * Update HIVB2DTLogic.cql * Fix sushi error * WSG-102 Profile Authoring (#52) * Profiling * Previous work * Fixed generation * Unintended change removed * Indicators 46-61 (#51) * 62-63 * ind 63 * Updated FSH --------- Co-authored-by: Patric Prado <[email protected]> Co-authored-by: Ian <[email protected]> Co-authored-by: Mutesasira Moses <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.