This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
fix: LEAP-523: Return region's text to item in a list #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Outliner left this important info from region items in the list. Returning it back.
We don't need to output it via dangerouslySetInnerHTML, it's not safe and that's just a text, not an html.
We had different versions at different places, assuming that it's always a polygon, but it can be a brush.
yyassi-heartex
approved these changes
Jan 22, 2024
|
/git merge master
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1674 +/- ##
==========================================
- Coverage 64.60% 64.60% -0.01%
==========================================
Files 443 443
Lines 28730 28734 +4
Branches 7526 7530 +4
==========================================
+ Hits 18561 18563 +2
- Misses 10169 10171 +2 ☔ View full report in Codecov by Sentry. |
With groupping by Label or Tool `item` is undefined
yyassi-heartex
approved these changes
Jan 25, 2024
Gondragos
reviewed
Jan 25, 2024
Co-authored-by: Sergey <[email protected]>
MasherJames
pushed a commit
to HelloPareto/label-studio-frontend
that referenced
this pull request
Feb 29, 2024
* fix: LEAP-523: Return region's text to item in a list New Outliner left this important info from region items in the list. Returning it back. * Simplify text output in Region Info panel We don't need to output it via dangerouslySetInnerHTML, it's not safe and that's just a text, not an html. * Make "Incomplete polygon/other type" consistent We had different versions at different places, assuming that it's always a polygon, but it can be a brush. * Add test for New UI and regions' texts * Fix it for different grouppings With groupping by Label or Tool `item` is undefined * Remove accidential Scenario.only * Fix excess symbol Co-authored-by: Sergey <[email protected]> --------- Co-authored-by: hlomzik <[email protected]> Co-authored-by: Sergey <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Outliner dropped this important info from region items in the list.
Returning it back.
PR fulfills these requirements
Describe the reason for change
We need to remove flags for Outliner and NEW UI, enabling it for everyone. To do this smoothly new UI should be very similar to old ones, and that's one of the most important differences.
What feature flags were used to cover this change?
Outliner
ff_front_1170_outliner_030222_shortNew UI
fflag_feat_front_dev_3873_labeling_ui_improvements_shortThis change affects (describe how if yes)
dangerouslySetInnerHTMLremovedDoes this PR introduce a breaking change?
What level of testing was included in the change?