Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

ci: New PR template #1613

Merged
merged 4 commits into from
Jan 25, 2024
Merged

ci: New PR template #1613

merged 4 commits into from
Jan 25, 2024

Conversation

hlomzik
Copy link
Collaborator

@hlomzik hlomzik commented Nov 8, 2023

Shorter version of our frontend PR template to encourage and help to make more thoughtful description and highlight important nuances of every PR.

Describe the reason for change

Current PR template usually left (mostly) untouched, because it has lot of items to read and change.

@hlomzik hlomzik requested a review from farioas as a code owner November 8, 2023 15:47
@github-actions github-actions bot added the ci label Nov 8, 2023
@farioas farioas removed their request for review November 9, 2023 10:08
Copy link
Contributor

@bmartel bmartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing. We should be using this as soon as possible 🔥

@hlomzik
Copy link
Collaborator Author

hlomzik commented Jan 25, 2024

/git merge master

Workflow run
Successfully pushed new changes:
Merge remote-tracking branch 'origin/master' into new-pr-template (bdc0e1c)

@hlomzik hlomzik enabled auto-merge (squash) January 25, 2024 17:33
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb446c9) 64.60% compared to head (bdc0e1c) 64.60%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1613   +/-   ##
=======================================
  Coverage   64.60%   64.60%           
=======================================
  Files         443      443           
  Lines       28730    28730           
  Branches     7526     7526           
=======================================
+ Hits        18560    18561    +1     
+ Misses      10170    10169    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hlomzik hlomzik merged commit b6bb8d2 into master Jan 25, 2024
13 of 14 checks passed
@hlomzik hlomzik deleted the new-pr-template branch January 25, 2024 18:27
MasherJames pushed a commit to HelloPareto/label-studio-frontend that referenced this pull request Feb 29, 2024
* ci: New PR template

* Fill in all sections; emphasize actions part

* Made some edits for clarity

---------

Co-authored-by: Caitlin Wheeless <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants