Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: LEAP-295: Fix error styles in LS modals #1600

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

hlomzik
Copy link
Collaborator

@hlomzik hlomzik commented Oct 23, 2023

Create Project modal's preview had broken styles

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

What does this fix?

Overrides styles from LS modal (it has white-space: pre-wrap for some reason)

Does this PR introduce a breaking change?

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

Create Project modal's preview had broken styles
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@hlomzik hlomzik merged commit 6f128ee into master Oct 26, 2023
15 checks passed
@hlomzik hlomzik deleted the fb-leap-295/error-styles branch October 26, 2023 20:09
MasherJames pushed a commit to HelloPareto/label-studio-frontend that referenced this pull request Feb 29, 2024
Create Project modal's preview had broken styles
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants