-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Phoenix Live Dashboard with Absinthe metrics #404
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
817e643
Attempt to get liveview dashboard working with graphql metrics
brianpeiris 60cb655
Merge remote-tracking branch 'origin/feature/graphql-dashboard' into …
johnshaughnessy 9ecb4bc
Upgrade dependencies
johnshaughnessy 32cbd8f
Upgrade deps
johnshaughnessy 139207f
Enable request logger
johnshaughnessy f37d7ca
Add absinthe metrics
johnshaughnessy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
defmodule RetWeb.Telemetry do | ||
use Supervisor | ||
import Telemetry.Metrics | ||
|
||
def start_link(arg) do | ||
Supervisor.start_link(__MODULE__, arg, name: __MODULE__) | ||
end | ||
|
||
def init(_arg) do | ||
children = [ | ||
{:telemetry_poller, measurements: periodic_measurements(), period: 10_000} | ||
] | ||
|
||
Supervisor.init(children, strategy: :one_for_one) | ||
end | ||
|
||
def metrics do | ||
[ | ||
# Phoenix Metrics | ||
summary("phoenix.endpoint.stop.duration", | ||
unit: {:native, :millisecond} | ||
), | ||
summary("phoenix.router_dispatch.stop.duration", | ||
tags: [:route], | ||
unit: {:native, :millisecond} | ||
), | ||
#Absinthe Metrics | ||
summary("absinthe.execute.operation.stop.duration"), | ||
summary("absinthe.resolve.field.stop.duration"), | ||
summary("absinthe.middleware.batch.stop.duration"), | ||
|
||
# VM Metrics | ||
summary("vm.memory.total", unit: {:byte, :kilobyte}), | ||
summary("vm.total_run_queue_lengths.total"), | ||
summary("vm.total_run_queue_lengths.cpu"), | ||
summary("vm.total_run_queue_lengths.io") | ||
] | ||
end | ||
|
||
defp periodic_measurements do | ||
[] | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we upgrade cowboy to 2.8, then we need to make sure we are running erlang 22+
See phoenixframework/phoenix#3950
It looks like we are running 22.0 in habitat deploys:
https://github.com/mozilla/hubs-ops/blob/master/plans/erlang/habitat/plan.sh#L3
Need to confirm this and check terraform / hmc