Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GraphQL API for managing rooms #399

Merged
merged 140 commits into from
Dec 14, 2020
Merged

Add GraphQL API for managing rooms #399

merged 140 commits into from
Dec 14, 2020

Conversation

johnshaughnessy
Copy link
Contributor

@johnshaughnessy johnshaughnessy commented Jul 30, 2020 •
edited
Loading

Adds a GraphQL API for querying/updating rooms.

image

Notes:

  • Would like to use same API over websockets.
  • Would like to add subscriptions action type.
  • Absinthe errors don't follow the graphql spec correctly -- we should be ready to upgrade or handle this ourselves: see absinthe issue 925 in their github repo.
  • The router does not use :secure_headers for the graphiql endpoint so that the CSP doesn't block jsdelivr. Would like to solve this a better way.
  • Would like add rate/complexity limiting
  • We can optionally update phoenix to get liveview, which will make adding absinthe metrics (via :telemetry) easier: Add Phoenix Live Dashboard with Absinthe metrics #404

robertlong and others added 24 commits July 15, 2020 18:10
@robertlong
GraphQL API WIP
98ed136
@robertlong
Fix formatting and remove inspect
55b1260
@robertlong
Use a changeset error handling middleware
bd512d5
@robertlong
Add pagination to public rooms query
3da617c
@robertlong
Add myRooms and authenticated routes
d396147
@robertlong
Add favorite rooms query
8ea148a
@robertlong
Add more room and scene fields
c28f8fb
@robertlong
Use dataloader for batch fetching scenes
6e718e1
@johnshaughnessy
Fix typo in comment
b269d9b
@johnshaughnessy
specify preferred json codec
ada6276
@johnshaughnessy
Add test cases for room query
bdc1f8d
@johnshaughnessy
DRY up tests
125769c
@johnshaughnessy
Remove unused "variables" from tests
6883a09
@johnshaughnessy
DRY : add assign_creator function
1a5853f
@johnshaughnessy
Rename put_auth_header_for_email
b585a8c
@johnshaughnessy
DRY: put_auth_header_for_account
002f1e9
@johnshaughnessy
DRY: graphql query
66d8c4a
@johnshaughnessy
Don't need to hit the iql api
b7c55e5
@johnshaughnessy
Test room creation. Add default creator assignment
96d27c8
@johnshaughnessy
Specify json_codec
6b4c0b6
@johnshaughnessy
Add room name to mutation result
fec3753
@johnshaughnessy
Test pagination
012d040
@johnshaughnessy
Fix warnings
0e3f85e
@johnshaughnessy
Formatting
8f2611c
This was referenced Aug 1, 2020
Closed
Closed
Closed
Open
Closed
Open
@johnshaughnessy
Fix query for favorite rooms
6afdb17
@johnshaughnessy
Define internal functions with defp
0c9638f
@johnshaughnessy
Fix call to internal function
9009d96
@johnshaughnessy
Remove max_page_size
4923a66 
This parameter affects existing API calls.
While I do not think it will cause any issues, I am removing
it for now because I want the changes to be isolated to the
new API as much as possible. I'd be happy to reintroduce this
later as-is, or before release if it targets this API specifically.
@johnshaughnessy
Fix credential changeset validation/constraints
016d737
@johnshaughnessy
Do not have all tokens end in "09"
832898b
@johnshaughnessy
Prefix the sid to the rest of the token
50f7df6
@johnshaughnessy
Update comment for Can impl for Atom
ec55da4
johnshaughnessy
johnshaughnessy commented Nov 17, 2020
View reviewed changes
test/api/v2/room_query_test.exs
defmodule RoomQueryTest do
@moduledoc """
Test absinthe queries on rooms
"""
Copy link
Contributor Author

@johnshaughnessy johnshaughnessy Nov 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Create full queries for graphql types.
We can use https://github.com/devonestes/assertions/blob/master/lib/assertions/absinthe.ex
(Example https://blog.appsignal.com/2020/08/19/testing-absinthe.html)

@brianpeiris brianpeiris mentioned this pull request Dec 11, 2020
Merged
@johnshaughnessy johnshaughnessy mentioned this pull request Dec 14, 2020
Open
@johnshaughnessy johnshaughnessy merged commit b80f8c9 into master Dec 14, 2020
@johnshaughnessy johnshaughnessy deleted the feature/graphql-2 branch December 14, 2020 20:00
This was referenced Mar 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentfretin vincentfretin vincentfretin left review comments

@brianpeiris brianpeiris brianpeiris requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnshaughnessy @brianpeiris @vincentfretin @robertlong