Bitecs avatar menu fixes #6328

keianhzo · 2023-10-13T10:30:35Z

Fixes #6308

This PR addresses three avatar inspect menu issues:

Shows the correct avatar menu when inspecting instead of the object menu
Fixes the avatar hide action that was crashing
Hides the next/prev menu for both new and old loaders as it does nothing for avatars (same behavior for AFrame)

takahirox

Honestly I'm not so familiar with our react stuffs so I just checked the added code, they look good to me.

keianhzo added 3 commits October 13, 2023 12:26

Show avatar menu when inspecting

3eb8c65

Fix avatar hiding

e7c37fc

Hide inspect prev/next menu for avatars

a214c39

keianhzo added P1 Address as quickly as possible new-loader labels Oct 13, 2023

keianhzo requested a review from takahirox October 13, 2023 10:30

keianhzo had a problem deploying to smoke October 13, 2023 10:40 — with GitHub Actions Failure

keianhzo had a problem deploying to hc-bio October 13, 2023 10:40 — with GitHub Actions Failure

takahirox approved these changes Oct 17, 2023

View reviewed changes

keianhzo merged commit 5711df6 into master Oct 19, 2023
10 of 12 checks passed

keianhzo deleted the bitecs-avatar-menu-fix branch October 19, 2023 15:37

Provide feedback