Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitECS: Fix Physics system issues when physics are generated but there are not meshes #6290

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

keianhzo
Copy link
Contributor

Fixes #6251

This PR fixes 2 issues (I didn't want to split this for such little code)

  1. We were ignoring the nav-mesh unless the scene was high density
  2. We were trying to generate mesh physics shapes for scenes without meshes. This was already happening for AFrame.

@keianhzo keianhzo requested a review from takahirox September 27, 2023 13:07
@keianhzo keianhzo added new-loader P1 Address as quickly as possible and removed P1 Address as quickly as possible labels Sep 27, 2023
@keianhzo keianhzo changed the title bitECS Fix Physics system issues when physics are generated but there are not meshes bitECS: Fix Physics system issues when physics are generated but there are not meshes Oct 3, 2023
@keianhzo keianhzo merged commit d570fa0 into master Oct 12, 2023
9 of 11 checks passed
@keianhzo keianhzo deleted the no-mesh-physics-fix branch October 12, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scenes without any mesh objects cause 1000s of physics errors
1 participant