bitECS: Check if entity has networked component before taking ownership #6258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keianhzo
force-pushed
the
bitecs-link-crash-fix
branch
from
1920a92 to
c34178c
Compare
takahirox
changed the title
|
Haven't looked into the details yet but let me share my impression for now. The expected behavior seems to do nothing when the preview image is clicked. So the fact that clicking it causes crash is weird to me because that means something interaction processing runs when it's clicked. I was thinking the root fix was not to run such interaction processing when the preview image is clicked. Anyways, I will look into details next week. To call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6254
This PR adds a check for Networked component when a Constraint is added to a body to taking ownership of entities that are not networked.
In some contexts we might want to add constratints to bodies of entities that are not networked. Inthe current use case most of the times this is the case as the only interactable entities are dropped medias but behavior graphs allow creating physics objects that can be interactable and might not necessarily need to be networked (although most of the times they will)