bitECS: Fix F key inspect #6246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds bitECS object list support. **Basic Strategy** Reuse the existing A-Frame based code as much as possible for now. In the related functions that take A-Frame element, take Object3D instead. Object3D has a reference to A-Frame element in the A-Frame based implementation and has a reference to Entity ID in the bitECS. The functions process with A-Frame element or Entity ID depending on whether new loader enabled. Explicitly use shouldUseNewLoader() and/or make two functions, one for A-Frame based and another one for bitECS based implementation, if different logics are needed between A-Frame based and bitECS based implementations. Duplicated codes may not be perfectly removed but it would be simpler to follow the code rather than the new loader pretends the old one. And it would be easier to edit the code when we will get rid of A-Frame. **Changes** - Introduce MediaInfo component and save url and content type into it when loading media in media-loader. The info is used in the object list - Fire listed_media_changed event when media is loaded via media-loader and when the loaded media entity is removed - Take Object3D instead of A-Frame element in the related functions - Use shouldUseNewLoader() and/or make two separated functions for A-Frame and bitECS where the different logics are needed **Future TODOs** - Support avatars - Support Pinning
This commit fixes F key inspect with the new loader enabled.
|
Closing this as it's already fixed by #6310 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6207
Requires #6067
This PR fixes the broken F key inspect with the new loader.
Please refer to #6207 (comment) for the root issue.