bitECS: Fix rotation with Object menu #6242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes roation operation with the Object menu. **Problem** Rotation focus is not released even if releasing mouse click if you release the space bar earlier than mouse click release. The root issue is heldExitQuery for handling mouse click release is not called if ObjectMenu.targetRef[menu] is not set. Then if ObjectMenu.targetRef[menu] is cleared by releasing the space bar earlier than releasing mouse click, heldExitQuery won't be called. **Solution** Always call heldExitQuery. **Changes** - Always call heldExitQuery - Save rotation/scale taget entity id when the operaton starts because rotation/scale are operated by dragging so that the operations can continue even if the cursor hovers off the target entity - Use the saved target entity id when the operation ends
johnshaughnessy
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6241
This PR fixes roation operation with the Object menu.
Problem
Rotation focus is not released even if releasing mouse click if you release the space bar earlier than mouse click release.
The root issue is
heldExitQueryfor handling mouse click release is not called ifObjectMenu.targetRef[menu]is not set.Then if
ObjectMenu.targetRef[menu]is cleared by releasing the space bar earlier than releasing mouse click,heldExitQuerywon't be called.Solution
Always call
heldExitQuery.Changes
heldExitQuery