bitECS: Clean up MediaImage/VideoLoaderData #6224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keianhzo
approved these changes
Sep 12, 2023
src/bit-systems/media-loading.ts
Outdated
| eid: EntityID, | ||
| { accessibleUrl, canonicalUrl, contentType, mediaType, thumbnail }: MediaInfo | ||
| ) { | ||
| // Note: For Image, Video, and Audio, additonal parameters can be |
There was a problem hiding this comment.
Typo: "additonal" -> "additional"
* Treat MediaImage/VideoLoaderData as part of MediaLoader component data. Less problematic because their life cycles will be synched with MediaLoader component. * Remove dependency with entity and MediaImage/VideoLoaderData from loaders in src/utils. The loaders will be simpler.
takahirox
force-pushed
the
CleanupMediaVideoImageLoaderData
branch
from
231514a to
f38b6ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up PR to #6111 for clean up.
MediaImage/VideoLoaderDataas part ofMediaLoadercomponent data. Less problematic because their life cycles will be synched with MediaLoader component.MediaImage/VideoLoaderData fromloaders insrc/utils. The loaders will be simpler.