Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major benefits
Breaking changes
KHR_materials_pbrSpecularGlossiness
extension supporthttps://github.com/mrdoob/three.js/wiki/Migration-Guide
Changes in the Hubs Client code base
uniform.luminance
touniform.luminanceSky
inskybox.js
to avoiduniform luminance
redefinition in the shaderlinearToRelativeLuminance()
toluminance()
in common shader Shaders: Renamed linearToRelativeLuminance() function mrdoob/three.js#24347*BufferGeometry
to*Geometry
to match the latest Three.js APIScene.autoUpdate
toScene.matrixWorldAutoUpdate
to match the latest Three.js APIDependencies
*BufferGeometry
. But Three.js has fallback now. It warns but*BufferGeometry
keeps working. I would like to suggest the warnings for now.GLTFLoader
that will be applied in r148 because they are needed for better LOD support. See https://github.com/MozillaReality/three.js/commits/hubs-patches-147postprocessing
doesn't support r147 yet. It supports up to r146 and blocks r147 install. As a workaround, I made a fork allowing r147 for now. It doesn't seem to cause any problem so far.TODO
package.json
andpackage-lock.json