WebRTC support #40
Merged
WebRTC support #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanenders
reviewed
Jul 14, 2023
There was a problem hiding this comment.
This is very clever, but I wonder if simple variable substitution wouldn’t be cleaner.
|
@bryanenders definitely, that's simpler. Thanks for that! Rebased and updated. |
takahirox
reviewed
Aug 29, 2023
Co-authored-by: Bryan Enders <[email protected]>
Co-authored-by: Bryan Enders <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for direct webrtc communication. There is another effort to support the relayed mode that only works on FF here: #16
Probably this setup is enough for local testing so it might be worth to close that one and merge this unless relayed mode support is important enough in local development/testing.