Scene Debugger followup PR #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exairnous
force-pushed
the
experimental/viewer-followup
branch
from
dba1b98 to
4478ee0
Compare
|
Hey @Exairnous this looks good to me, can you rebase with the latest master and fix the conflicts? Thanks! |
Display the forced glTF export parameters with their values in the UI of the scene debugger and include the reasoning on why they are forced to that state in their tooltips. Do not add `use_active_scene` to the export parameters or show it in the UI for Blender versions below 3.2 because these versions don't support it.
Exairnous
force-pushed
the
experimental/viewer-followup
branch
from
4478ee0 to
4a4d630
Compare
|
Rebased. Thanks! |
keianhzo
approved these changes
Dec 13, 2023
| } | ||
| if bpy.app.version >= (3, 2, 0): |
There was a problem hiding this comment.
Just curious does this do any harm if < 3.2.0? Does it crash?
There was a problem hiding this comment.
The use_active_scene export option isn't present in the glTF add-on in Blender versions under 3.2, so trying to include it causes the export to fail in those versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Displays the forced export options to the user in the UI along with the reasoning behind the hard-coded values in their tooltips and adds support for Blender versions below 3.2.
Depends on #249
Before:
After:
