Take LoadingType object union into account for FragmentStore #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b846ed9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for houdini-docs-next canceled.
|
✅ Deploy Preview for houdinigraphql canceled.
|
ewen-lbh
force-pushed
the
fix-fragment-store-type
branch
2 times, most recently
from
248b0e9
to
0775223
Compare
This comment was marked as outdated.
This comment was marked as outdated.
ewen-lbh
force-pushed
the
fix-fragment-store-type
branch
2 times, most recently
from
59d390a
to
5bcbc86
Compare
ewen-lbh
force-pushed
the
fix-fragment-store-type
branch
from
5bcbc86
to
c9d3466
Compare
ewen-lbh
force-pushed
the
fix-fragment-store-type
branch
from
bd8bf5a
to
b846ed9
Compare
net7toulouse
pushed a commit
to inp-net/churros
that referenced
this pull request
Nov 11, 2024
AlecAivazis
reviewed
Nov 13, 2024
| export type GraphQLDefaultScalar = string | number | boolean | ||
|
|
||
| export type GraphQLValue = GraphQLDefaultScalar | null | GraphQLObject | GraphQLValue[] | undefined | ||
| export type GraphQLLoadedValue = |
There was a problem hiding this comment.
Maybe i'm missing something but is there a problem with just updating GraphQLObject to always have the loaded value? If so, let's merge these 2 types with something like type GraphQLLoadedValue = GraphQLValue | LoadingType. Also, reading this outloud I think i would prefer a name like GraphQLValueWithLoading. a "loaded graphql value" sounds like it's already loaded (ie no loading values would be present).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1388
By defining new GraphQLLoadedValue & GraphQLLoadedObject types and including LoadingType in GraphQLValue's definition, every type in the library take could accept a loading value reflects this fact in its types. This allows typescript to infer things correctly
To help everyone out, please make sure your PR does the following:
pnpm run testsandcd integration && pnpm run testspnpm changeset