Improved dependency compatibility in the Harden Windows Security Module #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module will not detect if there was a problem loading its dlls and if it was, reloads PowerShell with -NoProfile switch to fix it. Also a new message will be shown when installing the AppControl Manager and there is an incompatible policy on the system.
3 tasks
There was a problem hiding this comment.
Copilot reviewed 5 out of 12 changed files in this pull request and generated no comments.
Files not reviewed (7)
- Harden-Windows-Security Module/Main files/Core/Confirm-SystemCompliance.psm1: Language not supported
- Harden-Windows-Security Module/Main files/Core/Protect-WindowsSecurity.psm1: Language not supported
- Harden-Windows-Security Module/Main files/Core/Unprotect-WindowsSecurity.psm1: Language not supported
- Harden-Windows-Security Module/Main files/Harden-Windows-Security-Module.psd1: Language not supported
- Harden-Windows-Security Module/Main files/Harden-Windows-Security-Module.psm1: Language not supported
- Harden-Windows-Security Module/Main files/Resources/XAML/AppControlManager.xaml: Language not supported
- Harden-Windows-Security Module/Main files/C#/Others/GlobalVars.cs: Evaluated as low risk
Comments suppressed due to low confidence (2)
Harden-Windows-Security Module/Main files/C#/GUI/AppControlManager/View.cs:371
- [nitpick] The error message is too long and might be confusing. Consider breaking it into shorter lines and clarifying the term 'self-signed with your on-device keys'.
Logger.LogMessage("Warning: A policy named 'Only elevate executables that are signed and validated' " +
Harden-Windows-Security Module/Main files/C#/GUI/AppControlManager/View.cs:356
- The new behavior introduced in the try block should be covered by tests to ensure it works as expected.
try
3 tasks
HotCakeX
deleted the
Improving-dependency-compatibility-with-other-modules
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module will now detect if there was a problem loading its dlls and if it was, reloads PowerShell with -NoProfile switch to fix it.
Also a new message will be shown when installing the AppControl Manager and there is an incompatible policy on the system.