Added Microsoft Recommended Block Rules auto update #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added Microsoft Recommended Block Rules auto update mechanism to the Create Policy page. It uses a scheduled task that runs weekly to keep it up to date. * Updated wiki documents to reflect the new auto update mechanism. * Improved the app's name appearance in the title bar. It was too white in the light theme that made it hard to read. * Added a horizontal separator line in the Code integrity information page to separate CI info from App Control info for better readability.
There was a problem hiding this comment.
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (3)
- AppControl Manager/MainWindow.xaml: Language not supported
- AppControl Manager/Pages/CreatePolicy.xaml: Language not supported
- AppControl Manager/Pages/SystemInformation/CodeIntegrityInfo.xaml: Language not supported
Comments suppressed due to low confidence (4)
AppControl Manager/Logic/Main/BasePolicyCreator.cs:140
- [nitpick] The comment could be more concise. Consider rephrasing to: 'Register the scheduled task, replacing any existing disabled or invalid task.'
// Register the scheduled task.
AppControl Manager/Logic/Main/BasePolicyCreator.cs:309
- Ensure that the removal of this logging statement does not impact the overall logging functionality.
Logger.Write("Displaying extra info about the Microsoft recommended Drivers block list");
AppControl Manager/Pages/CreatePolicy.xaml.cs:635
- [nitpick] The event handler name 'RecommendedDriverBlockRulesScheduledAutoUpdate_Click' is too verbose. Consider renaming it to 'AutoUpdateDriverBlockRules_Click' for consistency and clarity.
private async void RecommendedDriverBlockRulesScheduledAutoUpdate_Click(object sender, RoutedEventArgs e)
AppControl Manager/Pages/CreatePolicy.xaml.cs:662
- The error message 'An error occurred.' is not descriptive. Consider updating it to 'Failed to configure the scheduled task for auto-update.'
RecommendedDriverBlockRulesInfoBar.Message = "An error occurred.";
HotCakeX
deleted the
Added-Microsoft-Recommended-Block-Rules-auto-update
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Microsoft Recommended Block Rules auto update mechanism to the Create Policy page. It uses a scheduled task that runs weekly to keep it up to date.
Updated wiki documents to reflect the new auto update mechanism.
Improved the app's name appearance in the title bar. It was too white in the light theme that made it hard to read.
Added a horizontal separator line in the Code integrity information page to separate CI info from App Control info for better readability.