Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Add lintr Linting For R Packages #399

Open
TimothyWillard opened this issue Nov 15, 2024 · 1 comment
Open

[Feature request]: Add lintr Linting For R Packages #399

TimothyWillard opened this issue Nov 15, 2024 · 1 comment
Labels
enhancement Request for improvement or addition of new feature(s). low priority Low priority. meta/workflow Relating to CI / issue templates / testing frameworks / etc. r-flepicommon Relating to the flepicommon R package. r-flepiconfig Relating to the R configuration package. r-inference Relating to the R inference package.

Comments

@TimothyWillard
Copy link
Contributor

Label

enhancement, meta/workflow, r-flepicommon, r-flepiconfig, r-inference

Priority Label

low priority

Is your feature request related to a problem? Please describe.

To improve developer productivity it would be helpful to add R linting for flepicommon, flepiconfig, and inference. This would:

  1. Minimize the number of comments/discussions in PR that relate to R code formatting, and
  2. Act as an early warning for code smells or potentially problematic code.

Successor to GH-279.

Is your feature request related to a new application, scenario round, pathogen? Please describe.

n/a

Describe the solution you'd like

The defacto standard for linting R code is lintr. Might be wise to implement this on a per package basis, pick the smallest one first, work through the issues there and then move on to the others.

@TimothyWillard TimothyWillard added enhancement Request for improvement or addition of new feature(s). r-inference Relating to the R inference package. low priority Low priority. meta/workflow Relating to CI / issue templates / testing frameworks / etc. r-flepiconfig Relating to the R configuration package. r-flepicommon Relating to the flepicommon R package. labels Nov 15, 2024
@pearsonca
Copy link
Contributor

mild extension: should also be applying lintr to any side scripts outside the packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for improvement or addition of new feature(s). low priority Low priority. meta/workflow Relating to CI / issue templates / testing frameworks / etc. r-flepicommon Relating to the flepicommon R package. r-flepiconfig Relating to the R configuration package. r-inference Relating to the R inference package.
Projects
None yet
Development

No branches or pull requests

2 participants