Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Add pylint Or ruff Linting For gempyor #398

Open
TimothyWillard opened this issue Nov 15, 2024 · 0 comments
Open

[Feature request]: Add pylint Or ruff Linting For gempyor #398

TimothyWillard opened this issue Nov 15, 2024 · 0 comments
Labels
enhancement Request for improvement or addition of new feature(s). gempyor Concerns the Python core. low priority Low priority. meta/workflow Relating to CI / issue templates / testing frameworks / etc.

Comments

@TimothyWillard
Copy link
Contributor

Label

enhancement, gempyor, meta/workflow

Priority Label

low priority

Is your feature request related to a problem? Please describe.

To improve developer productivity it would be helpful to add python linting for gempyor. This would:

  1. Minimize the number of comments/discussions in PR that relate to python code formatting, and
  2. Act as an early warning for code smells or potentially problematic code.

Successor to GH-279.

Is your feature request related to a new application, scenario round, pathogen? Please describe.

n/a

Describe the solution you'd like

Either implement usage of pylint or ruff in similar style to GH-358. I don't have a strong preference, ruff seems to be the newer faster pylint, but pylint is tried and true. Whichever is easier to implement. We would need to change whatever the default line length is to match our current formatting with black, but otherwise I would be curious to see what issues are caught first before adjusting settings.

@TimothyWillard TimothyWillard added enhancement Request for improvement or addition of new feature(s). gempyor Concerns the Python core. low priority Low priority. meta/workflow Relating to CI / issue templates / testing frameworks / etc. labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for improvement or addition of new feature(s). gempyor Concerns the Python core. low priority Low priority. meta/workflow Relating to CI / issue templates / testing frameworks / etc.
Projects
None yet
Development

No branches or pull requests

1 participant