Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

movgrab: upstream Linux fix #76480

Closed
wants to merge 1 commit into from
Closed

movgrab: upstream Linux fix #76480

wants to merge 1 commit into from

Conversation

danielnachun
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@danielnachun danielnachun added linux to homebrew-core Migration of linuxbrew-core to homebrew-core license License PRs labels May 3, 2021
@iMichka
Copy link
Member

iMichka commented May 3, 2021

I think we should bump the revision here as we are moving from brewed libressl to system openssl on Mac. Wondering why it was using libressl though.

@SMillerDev
Copy link
Member

any way we could improve the test here? I doubt the current one would fail with these (or any) changes

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label May 28, 2021
@danielnachun danielnachun removed the stale No recent activity label May 28, 2021
carlocab
carlocab reviewed May 29, 2021
View reviewed changes
Formula/movgrab.rb
@@ -14,7 +14,11 @@ class Movgrab < Formula
sha256 cellar: :any, high_sierra: "7702b7817fc398f4901014bd6162578294da414a18b1ae4e5f10ef8cf05a678c"
end

depends_on "libressl"
Copy link
Member

@carlocab carlocab May 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to keep this. This was added in #49738, and the referenced issue (ColumPaget/Movgrab#3) is still open.

Good chance that this just disables SSL support entirely. We can probably just drop the revision bump too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to close this and align the Linux formula instead.

@danielnachun danielnachun deleted the movgrab branch June 13, 2021 05:27
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlocab carlocab carlocab left review comments

@iMichka iMichka iMichka approved these changes

Assignees
No one assigned
Labels
license License PRs linux to homebrew-core Migration of linuxbrew-core to homebrew-core outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielnachun @iMichka @SMillerDev @carlocab