Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rarian 0.8.6 #197783

Merged
merged 2 commits into from
Nov 15, 2024
Merged

rarian 0.8.6 #197783

merged 2 commits into from
Nov 15, 2024

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Nov 15, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Includes a migration from tinyxml to tinyxml2 using a patch from @alebcay merged upstream in https://gitlab.freedesktop.org/rarian/rarian/-/merge_requests/26. I believe this is the last dependent of tinyxml that isn't already deprecated, so after this we can revive the effort to deprecate tinyxml in #119829 (cc @SMillerDev).

Switches from tinyxml to tinyxml2.
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 15, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 15, 2024
Merged via the queue into Homebrew:master with commit c156302 Nov 15, 2024
15 checks passed
@scpeters scpeters deleted the rarian_0.8.6_tinyxml2 branch November 15, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants