Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whalebrew: add shell completions #108972

Closed
wants to merge 1 commit into from

Conversation

branchvincent
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Needs #107227 first

@BrewTestBot BrewTestBot added the go Go use is a significant feature of the PR or issue label Aug 26, 2022
@carlocab carlocab added the checksum mismatch SHA-256 doesn't match the download label Aug 26, 2022
@max-ae
Copy link
Contributor

max-ae commented Aug 26, 2022

This can use the DSL introduced in Homebrew/brew#13536, otherwise the cop from Homebrew/brew#13553 will fail once #105707 and Homebrew/brew#13553 are merged.

Formula/whalebrew.rb Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Sep 19, 2022
@github-actions github-actions bot closed this Sep 27, 2022
@branchvincent branchvincent deleted the whalebrew branch October 21, 2022 22:07
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
checksum mismatch SHA-256 doesn't match the download go Go use is a significant feature of the PR or issue outdated PR was locked due to age stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants