Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add devtools-x #183913

Closed
wants to merge 8 commits into from
Closed

feat: add devtools-x #183913

wants to merge 8 commits into from

Conversation

Hacksore
Copy link
Contributor

@Hacksore Hacksore commented Aug 30, 2024

i used the gh cli and grief this PR body 😂

tracking issue upstream: fosslife/devtools-x#63

Copy link

request-info bot commented Aug 30, 2024

Please provide a better issue/pull request title and/or description!

@krehel
Copy link
Member

krehel commented Aug 30, 2024

Thank you for your submission, but we cannot accept it at this time because it does not pass our signature verification check that are a requirement for new submissions:

macOS on ARM requires software to be signed. Please contact the upstream developer to let them know they should sign and notarize their software.

Please consider hosting this in your own Tap.

Additionally, regarding the PR template -- it contains a number of checkboxes for how to use brew tools to fix style and audit errors before pushing to GitHub.

@krehel krehel closed this Aug 30, 2024
@Hacksore
Copy link
Contributor Author

@krehel yup understood, my hands are tied here but if something changes upstream ill open a new one.

thanks!

@krehel
Copy link
Member

krehel commented Aug 30, 2024

No worries @Hacksore! Do recommend using the local tooling the brew team has developed - it'll save you a lot of time and headache!

@Hacksore
Copy link
Contributor Author

@krehel absolutely, but i had ran gh pr create --fill --draft which will yeet the template.

Next time ill use the template though!

@krehel
Copy link
Member

krehel commented Aug 30, 2024

@Hacksore That's fair, but I am referring to running brew style and brew audit locally. CI is going to run them and fail if the guides aren't met. You can run them locally and fix issues before pushing commits, is my point.

For example, I onSave action to run brew style --fix automatically, and run audits before commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants