[Tech] Don't compute log file locations when importing constants.ts
#3941
+33
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log file locations (
currentLogFile
,lastLogFile
,legendaryLogFile
, etc.) were computed when importing theconstants.ts
file, which in turn lead to a lot of code being ran & modules being imported, even if those values are never actually read.We can instead just use the common
initXXX
pattern to set the log file paths, andgetLogFile
to get them where they're needed.This doesn't have an immediate benefit, but makes testing slightly easier in the future. Instead of having to mock a lot of modules just to get a non-crashing test setup, you now need slightly less
I've tested all aspects of the app relating to log files. Code itself was not touched, so I only tested on Linux (since the only thing required to test was whether the functions actually ran at the correct time)
Use the following Checklist if you have changed something on the Backend or Frontend: