-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement 3rd layer single event screenshot and movie making and fetching prev/next image per source id #385
Merged
dgarciabriseno
merged 34 commits into
Helioviewer-Project:main
from
mudhoney:feature/next-prev-image
Jun 17, 2024
Merged
Implement 3rd layer single event screenshot and movie making and fetching prev/next image per source id #385
dgarciabriseno
merged 34 commits into
Helioviewer-Project:main
from
mudhoney:feature/next-prev-image
Jun 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mudhoney
commented
Jun 10, 2024
- Improve error handling
- Handle Validation errors seperately, also with JSON requests,
- Fix some doc urls
- Create HTTP POST endpoints for movie and screenshot creating
- Add JSON states to screeshot and movies tables,
- Handle both takeScreenshot with events and eventsLabel and postScreenshot with eventState seperately,
- Improve some error handling , more 500 s now
- Created db functions to fetch closest images per sources
- New eventsManager to handle both new events JSON and old eventsString and label
- Implement new single event handling in image frames ( required for movie and screenshots )
- Movie functions reQueueMovie , downloadMovie, queueMovie, takeScreenshot, downloadScreenshot to new logic
- Make region of interest free of params and options
- Change queue job to handle new events ,
- And tests
…tabs, fix small bug about inconsistent event_states
…it , fix statistics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.