-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zango project setup for cypress #318
base: test/cypress
Are you sure you want to change the base?
Conversation
05662fe
to
50d3cac
Compare
deploy/docker_compose.dev.yml
Outdated
- UID=${HOST_UID} | ||
- GID=${HOST_GID} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably use HOST_UID
and HOST_GID
instead of UID
and GID
as they are read only identifier and might throw error for some os images.(see logs here) These logs are from workflow run when I was using:
export UID=$(id -u)
export GID=$(id -g)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DevilsAutumn Make sense, we can also raise a separate PR for this change including changes in every places like dev dockerfile, prod dockerfile and docs
4df482d
to
0470626
Compare
@DevilsAutumn @shahharsh176 I think for conducting the e2e tests we should have the base docker image of Zango also built locally from the latest codebase? Are we doing this here or pulling the latest available Zango image from dockerhub? |
Also I feel Zango setup for testing should be a reusable workflow that should be referenced from the e2e tests instead of hardcoding it. We will need to reuse it in other types of tests as well that we will be implementing in future. @shahharsh176 @DevilsAutumn |
…ne-Technologies/Zango into zango_setup_for_cypress
yes @kc-diabeat , I have discussed it for building local docker image. Bhuvnesh is implementing it |
I've pushed the required changes, made few changes in cypress as well. Everything seems to be working fine. @kc-diabeat @shahharsh176 |
5ccb5a3
to
d63f848
Compare
No description provided.