Remote GI #3073
Remote GI #3073
Conversation
|
It looks like the Switch build is failing on SDL_net inclusion. Does the Switch toolchain not have an equivalent? |
No idea. Unless someone else wants to step in, this week I'm going to work towards just disabling all networking stuff on switch, similar to how we did before |
|
Note to self: Crowd control isn’t working properly on this branch. Effects go through but are all refunded on the CrowdControl side |
garrettjoecox
force-pushed
the
remote
branch
from
f60f9a5 to
b1ab143
Compare
garrettjoecox
force-pushed
the
remote
branch
from
b1ab143 to
f4cc4a2
Compare
|
The issues this caused with crowd control have been resolved 👍 |
garrettjoecox
force-pushed
the
remote
branch
from
70e7643 to
dd270c5
Compare
garrettjoecox
force-pushed
the
remote
branch
3 times, most recently
from
0cef2fc to
6a31def
Compare
garrettjoecox
force-pushed
the
remote
branch
2 times, most recently
from
783ed20 to
32cb517
Compare
| - name: Install latest SDL_net | ||
| if: ${{ !vars.LINUX_RUNNER }} | ||
| run: | | ||
| export PATH="/usr/lib/ccache:/usr/local/opt/ccache/libexec:$PATH" | ||
| wget https://www.libsdl.org/projects/SDL_net/release/SDL2_net-2.2.0.tar.gz | ||
| tar -xzf SDL2_net-2.2.0.tar.gz | ||
| cd SDL2_net-2.2.0 | ||
| ./configure | ||
| make -j 10 | ||
| sudo make install | ||
| sudo cp -av /usr/local/lib/libSDL* /lib/x86_64-linux-gnu/ |
There was a problem hiding this comment.
wild that this has been in that step for so long
| @@ -333,13 +282,13 @@ CrowdControl::Effect* CrowdControl::ParseMessage(char payload[512]) { | |||
| effect->category = kEffectCatDamageTaken; | |||
| effect->timeRemaining = 30000; | |||
| effect->giEffect = new GameInteractionEffect::ModifyDefenseModifier(); | |||
| effect->giEffect->parameters[0] = 2; | |||
| dynamic_cast<ParameterizedGameInteractionEffect*>(effect->giEffect)->parameters[0] = 2; | |||
There was a problem hiding this comment.
generally good practice to throw a != nullptr in there somewhere when dynamic casting, can be a follow up PR if you want to make a code cleanup issue for it
garrettjoecox
force-pushed
the
remote
branch
from
32cb517 to
26345e1
Compare
garrettjoecox
force-pushed
the
remote
branch
6 times, most recently
from
5c191e0 to
04a1cb0
Compare
Co-authored-by: David Chavez <[email protected]>
This PR succeeds #2538
The main goal here is to generalize the pattern of communicating over TCP sockets to 3rd party servers.
Summary
GameInteractor_RemoteclassGameInteractor_Sailwhich uses the remote (Paired with the repo here https://github.com/HarbourMasters/sail)Another example of the remote usage can be seen in Anchor (garrettjoecox#52)
Build Artifacts