Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove n_rows and levels_back parameters #361

Open
HenrikMettler opened this issue Jan 20, 2022 · 2 comments · May be fixed by #362
Open

Remove n_rows and levels_back parameters #361

HenrikMettler opened this issue Jan 20, 2022 · 2 comments · May be fixed by #362
Assignees
@HenrikMettler
Labels
API change The label that should be avoided maintenance Fighting the second law UX It's all about the experience
Milestone
0.4.0

Comments

@HenrikMettler
Copy link
Contributor

For historical reasons, our genome has parametersn_rows, levels_back. However they offer little benefit in optimization and in actual applications these are never used. To simplify things and improve the user experience we should remove these parameters.
@HenrikMettler HenrikMettler added maintenance Fighting the second law API change The label that should be avoided UX It's all about the experience labels Jan 20, 2022
@HenrikMettler HenrikMettler self-assigned this Jan 20, 2022
@HenrikMettler HenrikMettler added this to the 0.4.0 milestone Jan 20, 2022
@HenrikMettler
Copy link
Contributor Author

One question that arises, is whether we should also stop using the name n_columns and simply name it n_hidden since these things would become equal

@jakobj
Copy link
Member

jakobj commented Jan 21, 2022

yes, i think that would be a good idea. n_columns may be difficult to understand without the option of adding rows :D

@jakobj jakobj linked a pull request Jun 23, 2022 that will close this issue
Remove n_rows and levels_back from genome #362
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HenrikMettler HenrikMettler

Labels
API change The label that should be avoided maintenance Fighting the second law UX It's all about the experience
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

Remove n_rows and levels_back from genome HenrikMettler/hal-cgp
2 participants
@jakobj @HenrikMettler