93 threshold live #657
Merged
93 threshold live #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed histogram rendering position/artifacts Restore position of last threshold (couldn't figure out how to restore mode) Fixes HaikuArchives#93
Use `LeftTop()` instead of `BPoint(.left, .top)` for histogramRect in ThresholdView::Draw Check value of threshold control before resetting in ThresholdView::SetValue
humdingerb
reviewed
Dec 27, 2024
There was a problem hiding this comment.
I've tested the changes and they do fix the reported issues.
The code appears correct, but I'm not super familiar with ArtPaint's code as Dale did all the coding... :)
Let's leave the PR open for a few days longer, just in case Dale sees it and chimes in.
Thanks for providing the patch, @HiCamino !
korli
reviewed
Dec 28, 2024
korli
reviewed
Dec 28, 2024
|
@korli: satisfied with the changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have been looking at this project for a while and I am trying to fix some of these. This fix makes the Threshold add-on update when you drag the line in the histogram. I also fixed the drawing of the histogram.
Fixes #93