Add support for building on ARM64 MacOS #854
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gheskett
approved these changes
Jan 6, 2025
|
Donezo |
|
the lz4 tool errors out on mac, so I'll fix that in the meantime, too |
gheskett
requested changes
Jan 6, 2025
|
Addresses issued for both. lz4t no longer errors and make patch throws an assert |
gheskett
reviewed
Jan 6, 2025
gheskett
approved these changes
Jan 6, 2025
|
Yeah, patches on Linux, tells me to go get a better computer on mac |
gheskett
reviewed
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply added the measures to build on Mac. Have tested on both WSL and MacOS, both are building.
Flips has been stubbed out for Mac because I'm too stupid to figure out how to finagle make into doing my bidding. I don't consider this a blocking issue honestly.