Introduce batching engine and shadow batching #847
Conversation
include/sm64.h
Outdated
| enum BatchAlpha { | ||
| // coin frames batches, it goes 0, 1, 2, 3, 4, 3, 2, 1 | ||
| BATCH_ALPHA_COINS_FIRST, | ||
| BATCH_ALPHA_COINS_LAST = BATCH_ALPHA_COINS_FIRST + 4, |
There was a problem hiding this comment.
Idk how I feel about this, what does the 4 actually represent here, number of coin textures? If so, that should be defined somewhere, ideally automatically computed or enforced with a static assert if possible.
Ditto for the flames.
There was a problem hiding this comment.
I think the easiest solution is to add a static assert. sm64.h is a glue between subsystems geo->layer->batches->dls. It would be hard to deduce amount of coin textures without including actors in sm64.h which is not something I want to do.
For now I will remove those enums because they are unused anyways and reland them later with batching for specific objects.
There was a problem hiding this comment.
I have provided the static asserts for constant batches, it actually appeared to be pretty easy to implement.
There was a problem hiding this comment.
Could these be moved to batch_list.h? Idk if they make the most sense in sm64.h anyway, though to be fair the layer definitions are also here...
src/game/rendering_graph_node.c
Outdated
|
|
||
| static void main_render(Gfx **ptempGfxHead, struct DisplayListNode* currList, u32 mode1, u32 mode2, int phaseIndex) | ||
| { | ||
| (void)phaseIndex; |
There was a problem hiding this comment.
Is this a leftover compiler warning bypass?
There was a problem hiding this comment.
Yes, I prefer to be explicit here when silhouette is off. I have moved it under SILHOUETTE.
There was a problem hiding this comment.
Can you leave a short comment here too just to clarify it's a compiler warning bypass? You could also use the UNUSED keyword (though this is still messy)
gheskett
added
enhancement
This PR is introducing changes from #720 but in a more robust way by introducing generic batching engine. LayerBatches has unused values that are proposed for future if this PR will be accepted.