Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split camera.c #827

Open
wants to merge 32 commits into
base: develop/3.0.0
Choose a base branch
from

Conversation

someone2639
Copy link
Collaborator

@someone2639 someone2639 commented Aug 27, 2024

camera.c 11148 -> 3178 2441 lines

See README for details on file structure

TODO's for the PR:

  • Decide on whether it's worth adding a file for camera shake and camera sound

@gheskett gheskett added enhancement New feature or request cleanup Removal of useless or bloat code/features labels Aug 28, 2024
@gheskett gheskett added this to the 3.0 milestone Aug 28, 2024
@gheskett gheskett added the monkaS monkaS label Aug 28, 2024
@someone2639
Copy link
Collaborator Author

I believe this PR is ready for initial review. As always, the README has the intended file structure in case there are comments on that.

Things to consider:

  • Many enums and structs are still in camera.h, due to being a bit involved to separate into their uses (it would pollute the PR's changed files too)
  • The functions in Image 1 might warrant a new file, camera_sound.c
  • The functions in Image 2 might warrant a new file, camera_shake.c, or integration into the existing camera_math.c
  • I have put a function only used by the behind_mario mode in its respective file, but it might be worth placing it in camera_math.c instead.

Image 1:
image

Image 2:
image

@someone2639 someone2639 marked this pull request as ready for review August 29, 2024 17:57
@someone2639 someone2639 requested a review from gheskett as a code owner August 29, 2024 17:57
@someone2639 someone2639 changed the title Split camera.c (Tracking) Split camera.c Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Removal of useless or bloat code/features enhancement New feature or request monkaS monkaS
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants