New Crash Screen #466
New Crash Screen #466
Conversation
…+ document registerMaps + formatting
include/config/config_debug.h
Outdated
| @@ -8,7 +8,7 @@ | |||
| // #define DEBUG_ALL | |||
|
|
|||
| // Disables all debug options (except PUPPYPRINT). | |||
| #define DISABLE_ALL | |||
| // #define DISABLE_ALL | |||
include/sm64.h
Outdated
| extern char *__n64Assert_Message; | ||
| extern void __n64Assert(char *fileName, u32 lineNum, char *message); | ||
|
|
||
| #define ASSERT(cond, message) do {\ |
There was a problem hiding this comment.
imo if this is a runtime assert that follows the C standard then it should be named assert in all lowercase
There was a problem hiding this comment.
on second thought that requires a bit of extra work (including meddling with n64_assert.s and the assert parser) so consider this comment optional
src/crash_screen/crash_screen.c
Outdated
| }; | ||
|
|
||
| static const char *sRegNames[29] = { | ||
| "AT", "V0", "V1", |
There was a problem hiding this comment.
what happened to r0 lol (also theres 32 general registers where did the other 2 besides r0 go)
src/crash_screen/map_parser.c
Outdated
| extern u8 _goddardSegmentStart[]; | ||
| extern u8 _goddardSegmentTextEnd[]; | ||
|
|
||
| s32 is_in_code_segment(uintptr_t addr) { |
There was a problem hiding this comment.
if boot segment doesnt get overwritten it should be added here
…sing both Z and START
…nto develop/2.1.0-new-crash-screen
…nto develop/2.1.0-new-crash-screen
…nto develop/2.1.0-new-crash-screen
…nto develop/2.1.0-new-crash-screen
…elop/2.1.0-new-crash-screen
…elop/2.1.0-new-crash-screen
Co-authored-by: someone2639 <[email protected]>
…nto develop/2.1.0-new-crash-screen
Release: v2.1.2
…elop/2.1.0-new-crash-screen
…rt if assert message exists + some refactoring
|
Something I would like to see on this branch is a list of things this PR will do, so that scope is limited to only those things and I can gauge what parts I can contribute to (I'm willing to write the list but I do want mutual agreement here). |
|
Moving to new PR |
TODO: In-depth description still needed.