Added controls for most debug features and improved some #44
Conversation
| GfxPrint_Init(&printer); | ||
| GfxPrint_Open(&printer, newDList); | ||
| AudioDebug_Draw(&printer); | ||
| newDList = GfxPrint_Close(&printer); | ||
| GfxPrint_Destroy(&printer); | ||
| } | ||
| #endif |
There was a problem hiding this comment.
you can keep the variables here:
#ifdef ...
{
s32 variable;
...
}
#endifbtw "pad" is unused, can be removed
There was a problem hiding this comment.
I saw that kind of syntax in graph.c I believe and I was wondering if it was acceptable C syntax
There was a problem hiding this comment.
yes {} is just a block. in if () {} the {} isn't special syntax tied to the if, it just wraps some code under a single block that is the single thing below the if
| #define EVENT_EDITOR_CONTORLLER_PORT CONTROLLER_PORT_1 | ||
|
|
||
| // Set to true to use a button combo | ||
| #define EVENT_EDITOR_BTN_COMBO true |
There was a problem hiding this comment.
imo this sounds like it would be a BTN_ combination, not a boolean
There was a problem hiding this comment.
I need to cleanup some of the names yeah, this should be like EVENT_EDITOR_USE_BTN_COMBO
|
won't work on this more than that so marking as ready to review I guess, haven't tested since but I merged master and fix the typo |
Yanis002
changed the title
Yanis002
added
the
waiting for review
|
Reviewing this will take a bit longer I'll tell when I'm done |
|
I'm currently testing with every debug feature activated to ensure everything at all works so I won't be able to always tell which debugger could cause the respective problem Issue 1: Texture Flickering in Scenes that use "Box Textures" Update: I commented out the audio debugger. That one's causing a lot of problems it seems and i think it's unfinished Issue 2: Inventory not Drawing and stuttering sounds Issue 3: Opening up the Map Select collides with opening up the Camera Debugger That's probably not it. Didn't test everything, I will continue later on |
Yanis002
added
waiting for author
This PR adds controls in
config_debug_controls.hfor most debug features, also I improved a bit some of them, for instance I translated everything from the camera debugger, though the display is a bit glitched (but it works properly), I'd like to make further improvements to each features in the future™The camera debugger has A LOT of controls, that's why I put them at the end of the file otherwise it'd be awful to read imo, also I was lazy and didn't worked on the audio debugger yet, hence the draft state (just wanted to open a PR to get some opinions on things to improve)
Anyway, I hope you like it 👍