Create workflow for CI builds #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yanis002
added a commit
that referenced
this pull request
Jan 2, 2025
* In fix_bss.py, really always use BSS section start from map file (#2085) * [ntsc-1.2] Partially match z_en_mag (#2079) * Partially match z_en_mag * review * Match func_80AEEA48_unknown (thanks cadmic) * [ntsc-1.2] Match z_en_ge3 (#2078) * Match z_en_ge3 * change * Add all N64 version defines (#2095) * Add all N64 ROMs to versions.h * Remove OOT_ prefix from version defines * Make it pretty * [ntsc-1.2] Match z_vismono.c (#2091) * [ntsc-1.2] Match z_vismono.c * change match to use height Co-authored-by: cadmic <[email protected]> --------- Co-authored-by: cadmic <[email protected]> * [ntsc-1.2] Match system_malloc.c (#2080) * Match ntsc-1.2 system_malloc.c * CLEAR_INTERRUPTS -> DISABLE_INTERRUPTS * match PreRender_CopyImageRegionImpl (#2093) * [ntsc-1.2] Match a bunch of small stuff (#2094) * Match z_fbdemo_wipe1.c * Fix gDPSetTileCustom * Match z_eff_ss_dead.c * Match src/code/audio_thread_manager.c * Match z_parameter.c * Match KaleidoScope_DrawWorldMap * Format * 1 -> AUDIOMGR_DEBUG_LEVEL_NO_RSP * Actually match KaleidoScope_DrawWorldMap * Add comment on duplicate code * Revert "Fix gDPSetTileCustom" This reverts commit de09338d92e50dd3b9cb8ee7214e2e6b3fecf7ff. * T() macro 5 (#2089) * T() in __osMalloc.c * T() in code_80097A00.c * T() in debug_malloc.c * T() in code/load.c * T() in sys_math3d.c * T() in z_collision_btltbls.c, z_fbdemo_fade.c, z_fcurve_data_skelanime.c, z_view.c * T() in z_collision_check.c * remaining T() in __osMalloc.c * __osMalloc consistency * format * T() macro 6 (#2090) * T() in z_skelanime.c * T() in z_eff_blure.c * T() in z_play.c * T() in z_jpeg.c * T() in z_horse.c * T() in z_eff_spark.c * T() in z_malloc.c * T() in z_effect_soft_sprite.c * add todo on translating "確保" (litterally ~"secure", but may be better as "allocate"-ish) * review * format * Match functions using gDPSetTileCustom (#2100) * [Audio 6/?] Build Soundfonts and the Soundfont Table (#2056) * [Audio 6/?] Build Soundfonts and the Soundfont Table * Improve lots of error messages * First suggested changes * Make audio build debugging more friendly Co-authored-by: Dragorn421 <[email protected]> * Some fixes from MM review * Make soundfont_table.h generation depend on the samplebank xmls since they are read, report from which soundfont the invalid pointer indirect warning originates from --------- Co-authored-by: Dragorn421 <[email protected]> * [ntsc-1.2] Decompile fault.c (#2046) * wip decomp ntsc-1.2 fault.c * more ntsc-1.2 fault.c * decompiled fault_v1.c * name fault_v1 functions, wip * try to clean up build system (two versions of the fault system coexisting) * cleanup * cleanup2 * fix build gc-eu-mq-dbg * match 2 more, ty anon * matched * review * more review * fixup spec * `(uintptr_t)ptr op int` instead of `ptr op (type*)int` * move fault.h out of global headers, properly include fault.h and versions.h * compile all fault_*.c files regardless of version by overriding FAULT_VERSION * n64 FaultMgr.framebuffer s32 -> u16* * FaultMgr.framebuffer -> FaultMgr.fb * make gc FaultMgr.fb u16* (yes, thats everything) * bss * fix Fault_Printf return type * noop FaultDrawer_SetFontColor, FaultDrawer_SetCharPad in fault_n64 * fault_color_ stuff is only for fault_gc * rm empty line in makefile * I guess `D_80105A90_unknown` is `[sg]TotalAllocFailures` * bss * `Fault_WaitInput` -> `Fault_WaitForInput` * use named fault funcs in pointers array * FAULT_OOT{N64,GC} -> FAULT_{N64,GC} * Apply suggestions from code review Co-authored-by: Derek Hensley <[email protected]> Co-authored-by: Anghelo Carvajal <[email protected]> * review, sync fault_{gc,n64} * Apply `FPCSR_CE` suggestions from code review Co-authored-by: Derek Hensley <[email protected]> --------- Co-authored-by: Derek Hensley <[email protected]> Co-authored-by: Anghelo Carvajal <[email protected]> * Option to have MM's get item camera (#149) * mm get item camera Co-authored-by: Zeldaboy14 <[email protected]> * updated contributors --------- Co-authored-by: Zeldaboy14 <[email protected]> * post-merge build fixes * Check disasm metadata for missed renames (#2069) * Check disasm metadata (look for symbols in metadata that no longer exist, indicating renames but the metadata was not updated) * -us.z64 * Update disasm metadata with renamed functions in #2057 * sort IGNORE_NTSC_1_2_SYMS_MISSING * T() macro 7 (#2102) * T() macro in most of the rest of code (except z_message, z_actor, ucode_disas, gfxprint, game, fault, db_camera) * remaining T() macro in boot * format * review * [ntsc-1.2] Match z_game_over.c, PAL 1.1 fixes (#2099) * Match z_game_over.c (PAL 1.1 change) * Fix previous matches that are actually PAL 1.1 changes * Add versions.h to global.h * Add versions.h to z_game_over.c too * And the others too * Fix awkward wording * [ntsc-1.2] Match N64 libultra (#2081) * Match N64 libultra * INITIALIZE_FUNC -> OSINITIALIZE_FUNC * Document osGetIntMask * Refer readers of osGetIntMask to osSetIntMask comment * Whitelist new static functions in disasm unksyms check * [ntsc-1.2] Fix some data / disassembly / undefined_syms (#2103) * Fix some data splits * Use real fault functions in cic6105.c * Fix fault_n64.c data sizes * Format * Move driverominit and sprintf to src/boot/ (#2105) * [ntsc-1.2] Match z_demo.c, z_eff_blure.c, z_eff_spark.c (#2096) * Match z_demo.c * Match z_eff_blure.c * Match z_eff_spark.c (fake inc.) * review * improve EffectSpark_Draw match Co-authored-by: cadmic <[email protected]> * cleanup * fix merge * review * better match EffectBlure_DrawSimpleVertices (ty cadmic) * review * rm unneeded include versions.h --------- Co-authored-by: cadmic <[email protected]> * [ntsc-1.2] Match rand.c (#2097) * [ntsc-1.2] Match rand.c * Comment on N64 Rand_ZeroOne taking the low random bits Co-authored-by: Tharo <[email protected]> --------- Co-authored-by: Tharo <[email protected]> * Use FaultDrawer_ names in cic6105.c (#2108) * Target Docs [1/?] (#2110) * Target Docs Part 1 Co-authored-by: engineer124 <[email protected]> * review --------- Co-authored-by: engineer124 <[email protected]> * Document Target_Draw [Target Docs 2/?] (#2115) * document Target_Draw Co-authored-by: engineer124 <[email protected]> * fix missed renames * retail fix * another fix --------- Co-authored-by: engineer124 <[email protected]> * Target System Docs: Actor Searching [3/?] (#2120) * document target actor searching * missed something * review * mzx review * [ntsc-1.2] Import libleo from Decompollaborate/n64dd (#2104) * Create stack.h for STACK/STACK_TOP * Import libleo from Decompollaborate/n64dd Co-authored-by: Anghelo Carvajal <[email protected]> Co-authored-by: Elliptic Ellipsis <[email protected]> * Use (unsigned) int when in mdebug * Apply suggestions from code review Co-authored-by: Tharo <[email protected]> * Use && in leocmdex.c * Use proper names for character tables, revert sNonKanjiIndices * Fix incorrect OSMesg casts * Use LEO_ERROR_GOOD even where docs say 0 Co-authored-by: Tharo <[email protected]> * Remove "Presumably" comment * Whitespace * Remove redundant (debug-only) returns --------- Co-authored-by: Anghelo Carvajal <[email protected]> Co-authored-by: Elliptic Ellipsis <[email protected]> Co-authored-by: Tharo <[email protected]> * [ntsc-1.2] LoadFragment2 OK (#2118) * [ntsc-1.2] LoadFragment2 OK * Add insight about bssSize * [ntsc-1.2] Match audio (#2122) * general.c mostly ok * match remaining audio funcs * comments * Finish matching audio --------- Co-authored-by: engineer124 <[email protected]> * Document Target_Update [Target Docs 4/?] (#2123) * document Target_Update * add comments * try CLAMP (dbg is ok but ci will check retail) * Match stackcheck.c (#2107) * [ntsc-1.2] Match padmgr.c, sys_cfb.c, rcp_utils.c (#2111) * Match padmgr.c * Match sys_cfb.c, rcp_utils.c * Format * [ntsc-1.2] Match z_camera.c (#2112) * Add CAMERA_CHECK_BTN * Match Camera_Demo3 * Rename FaultDrawer_ functions to Fault_ (#2113) * Rename FaultDrawer_ functions to Fault_ * Rename FaultDrawer_Init to Fault_InitDrawer * [ntsc-1.2] Update spec for boot and code (#2114) * Update spec for boot and code * Fix merge * Match fp_math.c (#2116) * [ntsc-1.2] Match game.c, z_play.c, z_room.c (#2117) * Match z_room.c * Match game.c and z_play.c * Add undefined syms * Rewrite condition based on other file matches * Match KaleidoScope_DrawEquipment and KaleidoScope_DrawItemSelect (#2125) * Reorganize z_std_dma.c unused strings (#2121) Co-authored-by: Derek Hensley <[email protected]> * Run CC_CHECK in CI (#2109) * Run CC_CHECK in CI * Fix n64dd.h (guess this is why we need this change) * Pause: Name temps in `KaleidoScope_SetVertices` (#2088) * Pause doc: Name temps in `KaleidoScope_SetVertices` * Update src/overlays/misc/ovl_kaleido_scope/z_kaleido_scope.c Co-authored-by: cadmic <[email protected]> --------- Co-authored-by: cadmic <[email protected]> * [ntsc-1.2] Match __osMalloc.c and code_800FC620.c (new/delete) (#2106) * Match __osMalloc * Match src/code/code_800FC620.c (new/delete) * Wrap versions-specific files in ifdefs to fix compilation * Fix bss * Remove {FAULT,RAND,OSMALLOC}_VERSION in favor of PLATFORM_N64 * Fix __osMalloc data splits, add unused strings * __osMalloc.h -> osMalloc.h * Fix merge * fixed build issues * [ntsc-1.2] Partially match gfxprint.c (#2101) * [ntsc-1.2] Partially match gfxprint.c * yeet bss * fix * review * [Audio 7/?] Extract sequences to assembly (#2119) * [Audio 7/?] Extract sequences to assembly Co-authored-by: MNGoldenEagle <[email protected]> Co-authored-by: zelda2774 <[email protected]> * Suggested changes, some extra sequence disassembler cleanup * Remove unused multiprocessing import and regen assets/xml/audio/sequences --------- Co-authored-by: MNGoldenEagle <[email protected]> Co-authored-by: zelda2774 <[email protected]> * Jenkinsfile: `make -j` -> `make -j$(nproc)` (#2128) * unk_664 -> focusActor [Target Docs 5/?] (#2126) * unk_664 -> focusActor * capitalization * missed a temp * Cleanup: Pass all paths to tools rather than tools constructing them (#2017) * Pass all paths to tools rather than tools constructing them * fix: make --baserom-segments required * sync with mm reviews * --version everywhere * Pause doc: drawing the world map image (#2129) * [ntsc-1.2] Organize n64dd declarations and convert to 1.0 addresses (#2127) * Reorganize n64dd declarations * Fix bss * Really fix bss * [ntsc-1.2] Match z_message.c (#2098) * match Message_ResetOcarinaNoteState, Message_DrawTextChar * match Message_OpenText * Match Message_SetTables * Match Message_StartTextbox * forgor #if * format * match Message_DrawMain (ty inspect) * review * Fix merge issue between z_message.c match and n64dd renames (#2131) * Pause docs: `WorldMapArea` enum and related data (#2130) * Pause docs: WorldMapArea enum and related data * `WORLD_MAP_AREA_20` -> `_QUESTION_MARK` * bss * istargeted -> islockedon (#2132) * Target Mode Enum [Target Docs 7/?] (#2133) * TargetMode Enum * format * add default comment * bss * bss 2 * fix bss 3 * Update Room Documentation (#2015) * Update Room Documentation * Write more complete documentation, implement suggestions. * Function name changes; minor comment tweaks * nit * Resolve Dragorn fixes * Resolve Fig suggestions, fix comment wording * fix bss, fig suggestion * bss * Naming a function (#2124) * Naming a function * Naming function * Update functions.txt * Update function name * Update function name * Update function name * Update function name * Document `Target_ShouldReleaseLockOn` [Target Docs 8/8] (#2135) * target range and leash docs * format * Move button macros to include/controller.h (#2138) * Move button macros to include/controller.h * Fix z_mag button ordering * Clean up uses of !PLATFORM_N64 vs PLATFORM_GC (#2134) * Clean up uses of !PLATFORM_N64 vs PLATFORM_GC * Put N64 button colors first * Miscellaneous libultra header fixes (#2139) * Miscellaneous libultra header fixes * Fix bss? * Reword RCP timeout * Fix size of leoDiskStack (#2143) * [ntsc-1.2] Match z_actor_dlftbls.c (#2144) * Match z_actor_dlftbls.c * Update src/code/z_actor_dlftbls.c Co-authored-by: Dragorn421 <[email protected]> --------- Co-authored-by: Dragorn421 <[email protected]> * T() macro 8 (#2142) * T() macro in fault * T() macro in game.c, gfxprint.c * T() macro in ucode_disas.c * T() macro in z_actor.c * T() macro in z_message.c * push fault key combo T() * z_message T: koko -> "here" * format * [ntsc-1.2] Match more draw functions (#2145) * Match z_vr_box.c * Match TitleCard_Draw * Match z_player_lib.c? * Match Lights_Draw * [ntsc-1.2] Match z_file_choose.c and z_boss_tw.c (#2146) * Match z_file_choose.c * Match z_boss_tw.c * Format * end: -> close_disps: * [headers 7] Add sys_matrix.h (#2150) * add sys_matrix.h, based on MM's * move matrix debug macros to sys_matrix.h * bss * [headers 6] collision_check functions and structs (#2148) * [headers 6] collision_check functions and structs * bss * Pause doc: World map points (#2141) * Pause doc: World map points * bss * `WORLD_MAP_POINT_HYLIA_LAKESIDE` -> `_LAKE_HYLIA` * [ntsc-1.2] Match z_map_exp.c, z_map_mark.c (#2140) * Match z_map_exp.c, z_map_mark.c * Format * DMA_REQUEST_SYNC -> DmaMgr_RequestSync * Remove Gfx forward declaration * Move audio/general.c debug bss with the rest of bss (#2152) * Move audio/general.c debug bss to own file and include with the rest of bss * just inline the bss instead of include * Move `Graph_Alloc` and open/close Disps to `gfx.h` (#1976) * move graph_alloc and open/close Disps to gfx.h * zcolchk bss reeeeeee * fix matching gc-eu-mq (bss) * remove __gfxCtx extern * revert makefile -Werror=implicit-function-declaration * bss * Freeze SFX IDs in msgdis.py (#2154) * Freeze SFX IDs in msgdis.py * Remove remove_comments * Fix some boot and code data (#2155) * Target -> Attention (System Rename) (#2149) * TargetContext -> Attention * targetCtx -> attention * Target_ -> Attention_ * FindTargetableActor -> FindActor * targetableActorP -> attentionActorP * data vars (and 1 function I missed) * targetMode -> attentionRangeType * attention range enum comments * ATTENTION_RANGE_ * attention range data * TargetColor -> AttentionColor * missed one * fixup color variables * targetArrowOffset -> lockOnArrowOffset * focus pos comment * targetPriority -> attentionPriority * assets * loose-ends * Attention System Description * format * skj range type * enemy bgm * Match more GC button colors (#2156) * N64 ROM header (#2157) * [ntsc-1.2] Import n64dd code from Decompollaborate/n64dd (#2136) * Import n64dd code from Decompollaborate/n64dd Co-authored-by: Anghelo Carvajal <[email protected]> Co-authored-by: Elliptic Ellipsis <[email protected]> * Don't stub out missing textures * Remove @brief * Add low-effort file comments * Match OoT if style * Fix n64dd matching due to int vs long * Fix English n64dd error textures * Compress n64dd segment * Align n64dd to 0x40 --------- Co-authored-by: Anghelo Carvajal <[email protected]> Co-authored-by: Elliptic Ellipsis <[email protected]> * Pause doc: Trade quest marker (#2158) * Pause doc: Trade quest location * trade quest location -> marker * comment on tradeQuestMarker * rename gBuildTeam to gBuildCreator (#2160) * [headers 8] Add `main.h`, `segmented_address.h`, and changes for `main.c` symbols (#2151) * [headers 8] Add main.h and changes for main.c symbols * fix gSystemHeapSize is size_t only in MM * segmented_address.h * rm now useless include * actually commit segmented_address.h, oops * rm gGraphThread (faulty copypaste from MM) * bss * [headers 5] Misc small headers untangling (#2147) * Misc small headers untangling * mv gSaveContext to where it is in MM in the header * newline police * move rand functions back to functions.h * Document Attention/Lock-on Related Actor Flags (#2161) * document actor flags 0, 2, 3, and 27 * format * fly -> hover * wodring * Move some function declarations to `z64{interface,light,message}.h` (#2166) * Pause doc: Cursor drawing (#2159) * Pause doc: Cursor drawing * bss * Player Docs - Parallel (#2167) * name func and flag * rest of the docs * format and comment change * comment * Reorder spec segments for N64 versions (#2163) * fix_bss.py: Subtract addend for relocations against global symbols (#2169) * [headers 11] stackcheck.h, jpeg functions (#2171) * [headers 11] stackcheck.h, jpeg functions * bss * Document `ACTOR_FLAG_SFX_` flags and functions (#2162) * Document `ACTOR_FLAG_SFX_` flags and functions * format * [headers 9] Add src/libc64/ and new "z64" rand.h (#2164) * rand.h -> libc64/qrand.h * Add rand.h with z64 rand wrappers * yeet comment * code/rand.c -> libc64/qrand.c * fixup * move libc64 source to src/libc64/ * fix * bss * update file splits disasm metadata * Name `PLAYER_STATE1_ACTOR_CARRY` (#2173) * actor carry flag * format and add comments * comment changes * [headers 13] osMalloc.h -> include/libc64/os_malloc.h (#2175) * [headers 13] osMalloc.h -> include/libc64/os_malloc.h * also update the #includes :) * Run fix_bss.py in Jenkins and generate a patch (#2168) * fix_bss.py: Disable colors if stdout is not a tty * Run fix_bss.py in CI and output a patch * Wording tweaks * [Player ZTarget] Some func_80836BEC docs (#2172) * some func_80836BEC docs * review * fix * newline * linbreak * format * usingHoldTargeting * fix_bss.py: Restore z_locale special case (#2179) * fix build issues * Boomerang related state flags (#2180) * boomerang state flags * finish comment * Added eye texture offsets for extraction for object_oE5.xml (#2181) * Blob object_oE5_Blob_003A40 corrected to extract eye half open and eye closed textures for object_oE5 * Fixed spacing in object_oE5 xml file for commit * More target related state flags (#2184) * name some more flags * format * cdi suggestion * Cleanup gSPMatrix, rename `Matrix_New` -> `Matrix_Finalize`, add `MATRIX_FINALIZE_AND_LOAD` (#1983) * clean up gSPMatrix usage * add weird hybrid macro gSPMATRIX_SET_NEW * Matrix_NewMtx, MATRIX_NEW -> Matrix_Finalize, MATRIX_FINALIZE * gSPMATRIX_SET_NEW -> MATRIX_FINALIZE_AND_LOAD * format * [headers 12] Add kaleido_manager.h, move various protos to headers (#2174) * [headers 12] add kaleido_manager.h, move various protos to headers * BSS * bss * [headers 14] libc64 headers (#2177) * [headers 14] libc64 headers * bss * bss * [ntsc-1.2] Match remaining functions (#2182) * Match remaining ntsc-1.2 functions * "fake" -> "Fake match?" * [ntsc-1.2] Match N64 audio tables (#2183) * Match N64 audio tables * ifdef PERMANENT_POOL_SIZE rather than EXTRA_SIZE * Make needed extracted directories in extract scripts (#2185) * Pause doc: Prompt page and save prompt state (#2170) * Pause doc: Prompt page and save prompt state * bss * `QUAD_PROMPT_` -> `PROMPT_QUAD_` * `QUAD_MAP_WORLD_`, `QUAD_MAP_` -> `WORLD_MAP_QUAD_` * `PAUSE_QUAD_CURSOR_` -> `PAUSE_CURSOR_QUAD_` * `PAUSE_SAVE_PROMPT_STATE_RETURN_TO_MENU_ALT` -> `_2` * bss * bss * add comments to help clarify save prompt vs prompt * Colliders: colType -> colMaterial (#2186) * colType -> colMaterial * fixups * Add OOT_PAL_N64 and move other shorthands to versions.h (#2188) * Move definitions of OOT_NTSC/OOT_PAL/OOT_MQ to versions.h * Add PAL_N64 shorthand * [ntsc-1.2] Match ntsc-1.2 BSS and add to CI (#2187) * Match ntsc-1.2 * Add ntsc-1.2 to CI * Apply fixes from Jenkins * Promote ntsc-1.2 to "supported" in Makefile * Declare D_80858AD8 as a u64 array * Tweak wording * Hopefully make ntsc-1.2 bss more stable * Restore segmented_address.h include * Delete disassembly data for ntsc-1.2 (#2178) * Fix find command error (#2192) * change flag name (#2194) * Hostile Lock-On (#2193) * document flag and functions * format * adjust comment * make the comment more public-facing-friendly * Use gSpiritBossNabooruKnuckleDefeatCs instead of gMinuetCs in sCutscenesUnknownList (#2195) * More Player Z Target documentation (#2196) * document flag * Player_FriendlyLockOnOrParallel * quirk * z target functions * more comments * more comment changes * format * comment change * [Audio 8/?] Check-in handwritten sequences, build sequences, automate various sfx arrays (#2137) * [Audio 8/?] Check-in handwritten sequences, build sequences, automate various sfx arrays * Fix whitespace in aseq.h * Fix sequence 0 sfx id generator * Suggested changes, adjust some MML syntax and add more instruction descriptions * Correct some formatting in aseq.h * Add the dir of the input .seq file to the list of includes to sequence assembling so that assembler-level includes like .include or .incbin work intuitively * aseq.h tweaks * MM review suggestions, aseq.h adjustments * [PAL N64] Match changes that first appear in NTSC 1.2 (#2201) * Document `zTargetActiveTimer` (#2200) * document zTargetActiveTimer * edit comments * Update src/overlays/actors/ovl_player_actor/z_player.c Co-authored-by: cadmic <[email protected]> * capitalization --------- Co-authored-by: cadmic <[email protected]> * [PAL N64] Rename file select assets (#2197) * Name `PLAYER_STATE1_CHARGING_SPIN_ATTACK` (#2203) * name charge state flag * format * Colliders: elemType -> elemMaterial (#2189) * elemType -> elemMaterial * format * [PAL N64] Match VI mode setup (#2198) * `PLAYER_STATE1_DEAD` (#2204) * PLAYER_STATE1_DEAD * change comment * format * Consistently use "OOT_VERSION <" and "OOT_VERSION >=" (#2199) * Pause doc: Pages drawing (#2190) * name main fields and regs for pages drawing * comments * format * more comments * roll -> pitch (oops) * Document `PauseContext.offsetY`, `R_PAUSE_OFFSET_VERTICAL` as "y origin 1/2" * copypaste comment on page pitches fields * "offset depth" -> "depth offset" * review * [PAL N64] Match actor changes that aren't in NTSC 1.2 or GC releases (#2208) * [PAL N64] Match actor changes that aren't in NTSC 1.2 * Add bug comment about Zora's Domain waterfall * [PAL N64] Create macros for 50-Hz-related values (#2206) * [PAL N64] Create macros for 50-Hz-related values * Use FRAME_RATE_DEPENDENT for player speeds and boot data too * FRAME_RATE_DEPENDENT -> FRAMERATE_CONST * [headers] z64inventory.h, move savectx/inventory macros to z64save.h (#2209) * [headers] z64inventory.h * move savectx/inventory macros to z64save.h * commit the file * bss * [PAL N64] Match handwritten audio sequences (#2210) * [PAL N64] Match handwritten audio sequences * Remove offset comments from PAL-only audio code * Reorder includes * Document `autoLockOnActor` (#2212) * document autoLockOnActor * format.py * backtick * grammar * comment adjustments * word * letter * PLAYER_STATE1_ACTOR_CARRY -> PLAYER_STATE1_CARRYING_ACTOR (#2213) * Partially document idle animations (#2092) * Idle animation sfx entries * Function & array * Cleanup * I always forget format * Remove entry from names * Move comment * Replace animation "indices" with comment * Apply suggestion * Standardize "ActorMovement" over "ActorMove" (#2214) * ActorMove -> ActorMovement * more move -> movement * ANIM_FLAG_ENABLE_MOVEMENT * format * [headers] Move z_actor functions to z64actor.h (#2216) * move * format * bss * Document Player Knockback related functions (#1601) * document knockback related functions * rotation -> yRot * implement some changes * Renames and comments * mq bss * format * Intangibility and Invulnerability * bss * .bss * add #pragma increment_block_number to z_en_item00.c * .bss * [PAL N64] Miscellaneous changes (#2211) * [PAL N64] Miscellaneous changes * Reword comment Co-authored-by: fig02 <[email protected]> * glitch -> Glitch --------- Co-authored-by: fig02 <[email protected]> * Z-Targeting Loose Ends (#2217) * Z-Targeting loose ends * format * add stateflag comment * typo * unname PLAYER_STATE1_19 for now * tweak parallel comment * one more tweak * Pause doc: `KaleidoScope_DrawQuestStatus` (partial) (#2215) * Pause doc: `KaleidoScope_DrawQuestStatus` (partial) * review * format * create ucode_disas.h (#2222) * ucode_disas.h * create UcodeType * bss * [headers] gfx_setupdl.h and z64skin_matrix.h (#2221) * [headers] gfx_setupdl.h and z64skin_matrix.h * include z64skin_matrix.h * bss * bss * Pause docs: Songs playback (#2220) * Pause docs: Songs playback * `VREG(21-25)` -> `VREG(21) to VREG(25)` * comments on quest-song related main states * make `sPlayedSongBtns` `+1`-sized to account for trailing INVALID button note in a 8-btn-notes song * [headers] audio functions to z64audio.h and z64ocarina.h (#2223) * [headers] audio functions to z64audio.h and z64ocarina.h * bss * ActionChange -> ActionHandler (#2219) * [headers] Create letterbox.h, move more protos from functions.h (#2225) * [headers] Create z64shrink_window.h, move more protos from functions.h * format * include * bss * letterbox.h * Player Docs: `Player_ActionChange_6`, Rolling and Put Away (#1949) * progress * changing branches * start comments * last few changes * name the handler after rolling only * comment tweak * format * [PAL N64] Match z_message.c (#2202) * Player: `Player_ActionHandler_Talk` (#2226) * document Player_ActionHandler_Talk * format * comment tweak * review * capitalization * Pause docs: Quest quads (#2224) * Pause docs: Quest quads * `QUAD_QUEST_` -> `QUEST_QUAD_` * [ntsc-1.0/1.1] Match actor changes introduced in PAL 1.0 (#2227) * [ntsc-1.0/1.1] Match z_boss_ganon.c and z_boss_ganon2.c changes from PAL 1.0 (#2228) * Fix typos found by codespell (#2229) * format * [PAL N64] Set up build system and extract assets for pal-1.0 and pal-1.1 (#2205) * [PAL N64] Set up build system and extract assets * TOOD -> TODO * Apparently this is what the formatter wants * [headers] Move libultra protos to ultra64.h (as a temporary measure) (#2234) * [headers] Move libultra protos to ultra64.h (as a temporary measure) * format ultra64.h * bss * bss * bss * [includes] Explicit global.h includes for z_player (#2235) * [ntsc-1.0/1.1] Match z_player.c (#2232) * [ntsc-1.0/1.1] Match z_player.c * Move braces around * Use #if around only part of complicated conditions * [headers] z64bgcheck.h functions (#2239) * [headers] z64bgcheck.h functions * format * bss * Pause doc: Quest page cursor movement (#2236) * Fixed release mode (#152) * fixed release mode * format * move NDEBUG to the safeguards to allow building without RELEASE * forgor to revert a test thing * remove the todo for segment symbols * fix make_options * [headers] Create `gfxalloc.h`, `map.h`, move protos to `gfx.h`, `z64{player,view}.h` (#2233) * [headers] Create gfxalloc.h, map.h, move protos to z64{actor,player,view}.h * oops * bss * comment on player_lib protos & format * format map.h * Move SCREEN_{WIDTH,HEIGHT} and SET_FULLSCREEN_VIEWPORT to z64view.h * bss * revert move screen_width/height * bss * [includes] z_fishing (#2242) * [ntsc-1.0/1.1] Match PAL 1.0 viconfig changes (#2231) * [ntsc-1.0/1.1] Match viconfig changes * SREG(48) -> R_VI_MODE_EDIT_STATE * Pause doc: Item page quads (#2238) * Pause doc: Item page quads * format * rm AMMO_{FIRST,MAX,LAST}, _UNITS -> _ONES * add back ITEM_QUAD_AMMO_FIRST (oops) * units -> ones (continued) * [PAL N64] Match file select language selection (#2240) * [PAL N64] Match file select language selection * sInitialLanguageInputTimerY -> sInitialLanguageInputTimerX * [PAL N64] Completely match pal-1.0 and pal-1.1 and add to CI (#2246) * [PAL N64] Match pal-1.0 and pal-1.1 and add to CI * bss fixes from Jenkins * Name Talking Related Actor Flags (#2230) * document talking related actor flags * tweak comment * review * tweak * accept -> accepted * add more clarification * [ntsc-1.0/1.1] Match "game engine" files (#2244) * [ntsc-1.0/1.1] Match "game engine" files * Use R_START_BTN_X/R_START_BTN_Y * Comment obvious bugs * Move Magic_Fill comments * Move EVENTINF_HORSES_INDEX printf inside #if * Replace "this function" * [headers] Create zelda_arena.h, move protos to z64effect.h, and misc fixups (#2248) * [headers] Create z64malloc.h, move protos to z64effect.h, and misc fixups * zelda_arena.h * bss * bss2 * bss3 * bss * [headers] Create `one_point_cutscene.h`, `z64olib.h` and move stuff to `z64{object,player,scene}.h` (#2250) * [headers] Create `one_point_cutscene.h`, `z64olib.h` and move stuff to `z64{object,player,scene}.h` * bss * sSceneCmdHandlers * bss * bss * [ntsc-1.0/1.1] Match actor changes introduced in NTSC 1.1 (#2251) * [ntsc-1.0/1.1] Match actor changes introduced in NTSC 1.1 * SPHERE_DAMAGE -> FLARE_DANCER_BODY_DMG * Fix Actor_SetPlayerKnockbackLargeNoDamage merge * Actor flag: `ACTOR_FLAG_CARRY_X_ROT_INFLUENCE` (#2237) * document x rot carry flag * tweak comment * typo * review * flag tweak * Pause doc: item page cursor movement (#2249) * doc item page cursor movement * review * Fix build on certain Linux distributions (#2257) * Add missing HS_FISHING constant (#2256) * Add missing HS_FISHING constant * It's actually doubly-bugged lol * Format * Document bug in Camera_BGCheckInfo (#2258) * Player: AnimMovement (#2245) * name top level stuff * newlines * Document Player AnimMovement * tweak comment * spelling * review * rework comment * Player: Special Idle Animations (#2259) * document special idle anims * review * format * remove SPECIAL_IDLE_ANIMSFX_MAX * [includes] z_collision_check.c (#2252) * [includes] z_collision_check.c * bss * Document `Player_ChooseNextIdleAnim` (#2262) * document most of Player_ChooseNextIdleAnim * finish documenting Player_ChooseNextIdleAnim * capital letter * dummy block numbers for the script * fix bss * bug comment * SpeicalIdle -> Fidget, clean up related things * fix rng chance comment * normal -> default * rework Player_CheckForIdleAnim * swap idle anim defines * remove COMMON_FIDGET * add ARRAY_COUNT_2D * change macro def * [ntsc-1.0/1.1] Match line numbers in debug strings (#2255) * [ntsc-1.0/1.1] Extract assets (except audio) for ntsc-1.0 and ntsc-1.1 (#2253) * [ntsc-1.0/1.1] Extract assets (except audio) for ntsc-1.0 and ntsc-1.1 * Fix merge with pal-1.0/1.1 * [ntsc-1.0/1.1] Match "system" files (#2254) * [ntsc-1.0/1.1] Match audio library (#2243) * [ntsc-1.0/1.1] Match audio library * Don't include versions.h in audio table headers * Include versions.h where audio tables are used * Player doc: some rotation logic/data (#1443) * Docs: some player rotation logic/data * Improve misleading comment * rename temps * unk_6AE_rotFlags * format * disasm metadata * name action wrappers (#2261) * Pause doc: misc, fixups (#2265) * use missed reg macros * do action indexing cleanup * misc * doc fixup ish in KaleidoScope_SetPageVertices * newline_police * `43` -> `(PAGE_BG_QUADS + WORLD_MAP_QUAD_28)` * Document `Player_Action_Idle` (#2266) * document Player_Action_Idle * Player_DecelerateToZero * cleanup R_RUN_SPEED_LIMIT usages * format * typo * reorder reg * shake timer is used for fall damage * comment on shake timer only being processed in one place * format and edit comment * shakeTimer -> fallDamageStunTimer * Name talking action related things (#2260) * name talking related things * Player_Action_TalkExchangeItem -> Player_Action_ExchangeItem * splitting action stuff to new PR * format * Use MASS_IMMOVABLE/MASS_HEAVY everywhere (#2269) * Document `Player_Action_TurnInPlace` (#2268) * document turn in place * format * modify comments * sWaterSpeedFactor * Document `Player_Action_SwingBottle` (#2263) * Document Player_Action_8084ECA4 * Name func_8083721C * Add note * Move BottleCatchAnimationData declaration * Apply format * Revert "Name func_8083721C" This reverts commit aeb7ea83abf470e81f88056e577bd1fb796ad7ec. * Revert "Merge branch 'main' of github.com:zeldaret/oot into bottle-info" This reverts commit 10f1a4500368a66097c80cdb08f86ff2456ba9fb, reversing changes made to 547280abf2a041a8f6884d43b2eada7802c7feec. * Reapply "Merge branch 'main' of github.com:zeldaret/oot into bottle-info" This reverts commit e9bf122be5a5641d31238d53c7ba788e560d8dd1. * Some more bottle docs (#1) * more docs * struct comments * format.py * Revert "Merge branch 'main' of github.com:zeldaret/oot into bottle-info" This reverts commit 10f1a4500368a66097c80cdb08f86ff2456ba9fb, reversing changes made to 547280abf2a041a8f6884d43b2eada7802c7feec. * add clarifying comment * review, fix bss --------- Co-authored-by: fig02 <[email protected]> * Rename RoomBehaviorType2 (#2270) * Rename RoomBehavior2 * fig proposal * fig comment * Minor en_changer and en_bom_bowl_man documentation update (#2272) * minor en_changer documentation update * rename EnChanger->chestOpened to selectedChest, formatting * update asm comment on EnChanger_OpenChests * use EnExItemType enum instead of EXITEM_COUNTER define * Document `Player_Action_8084F390` (#2264) * Document Player_Action_8084F390 * Rename linkYawToStepTowards into shapeYawTarget * Fix BSS * Address reviews * Fix format * Address Review * Rename RoomBehaviorType1 to RoomType (#2271) * Rename RoomBehaviorType1 to RoomType * suggestions * Update include/z64scene.h --------- Co-authored-by: fig02 <[email protected]> * Add multiversion instructions to README (#2247) * Add multiversion instructions to README * Direct users toward Makefile * Modify options "below" instead of "in the Makefile" * Reword * EnHy + objects docs (#1499) * document object_bba * Clean up cne * object bob * object_aob * object_cob * object_bji * object_ahg * object_boj * All functions named plus some cleanup * enums * Remove body wiggle comments * Format * Remove case comments * comments with default * Format * format * Document `ACTOR_FLAG_THROW_ONLY` (#2274) * document ACTOR_FLAG_THROW_ONLY * flip function name * add comments * format * fix build issues * Document `ACTOR_FLAG_UPDATE_DURING_OCARINA` and `PLAYER_STATE2_USING_OCARINA` (#2277) * Document ACTOR_FLAG_UPDATE_DURING_OCARINA * document PLAYER_STATE2_USING_OCARINA * format * comment tweak * treat var as flag * Create workflow for CI builds (#153) * create build workflow (no artifacts) * fix url * fix lowercase issue * fix build oddities * update matrix * Document `ACTOR_FLAG_SFX_FOR_PLAYER_BODY_HIT` (#2276) * name ACTOR_FLAG_HIT_PLAYER_THUMP_SFX * ACTOR_FLAG_HIT_PLAYER_THUMP_SFX -> ACTOR_FLAG_SFX_FOR_PLAYER_BODY_HIT * Document `ACTOR_FLAG_CAN_PRESS_SWITCHES` (#2275) * document switch activation * format * activate -> press * fix comment * Remove hardcoded bash location in tools/preprocess.sh (#2280) * Remove hardcoded bash location in tools/preprocess.sh * Add more tolerant shebang to tools/preprocess.sh * Document `PLAYER_STATE1_SHIELDING` (#2279) * Document `PLAYER_STATE1_SHIELDING` * Fix format * Missing python3-venv in Dockerfile (#2282) * libu64 (#2267) * libu64 * logutils.o -> debug.o in spec * stackcheck.c is part of libu64 * review * add paragraph about Overlay_Load calling an external function * audio code* * `ACTOR_FLAG_ENKUSA_CUT` -> `ACTOR_FLAG_GRASS_DESTROYED` (#2285) * rename enkusa cut to bush destroyed * bush -> grass * clump * Document Arrow Related Actor Flags (#2284) * name arrow actor flags * fix flag check * [ntsc-1.0/1.1] Match audio and loose ends (#2293) * Match ntsc-1.0/1.1 loose ends * Revert audioseq_padding * Fix spelling * [Audio 9/?] Multiversion samplebank and soundfont extraction xmls, 1.0 and 1.1 audio extraction (#2291) * [Audio 9/?] Multiversion samplebank and soundfont extraction xmls, 1.0 and 1.1 audio extraction * Rework multiversion samplebanks to reduce duplicates * Use the T macro in z_select (#2273) * Use the T macro in z_select * Address reviews * Apply Format * Fix day & night * Completely match ntsc-1.0/1.1 bss and add to CI (#2294) * fix_bss.py: Fix infinite loop after linker errors (#2297) * Document `enum PauseState` game over parts (#2283) * [document] `enum PauseState`, game over parts * apply Jenkins fixes (automatic code formatting) also, as previously, i've rerun the "make" to check integrity * add `PAUSE_STATE_GAME_OVER_*` comments in case it helps to rename them later, if the need ever arises * improve `PAUSE_STATE_GAME_OVER_SAVE_*` comments also i've noticed, that `z64pause.h` doesn't comply fully with the `.clang-format` temporary changing a couple of setting to - ColumnLimit: 0 - AlignTrailingComments: false fixes the issue. i don't want to push unrelated formatting here * remove redundant comments zeldaret/oot#2283 (comment) * apply PR naming suggestions reverified with > `check_format.py ...` > `make ...` * Use debug macros even in N64-only code (#2298) * Use debug macros even in N64-only code * Use UNK_FILE/UNK_LINE instead * Decouple Debug Features From gc-eu-mq-dbg (#2296) * rename OOT_DEBUG to DEBUG_FEATURES * makefile changes * add DEBUG_ASSETS * fix DEBUG_FEATURES usages * format * fix errors * review * fix problem and review2 * review * add DEBUG_FEATURES to DEBUG_ASSETS check * review * whoops * format * Fix VROM address handling in sym_info.py (#2292) * Player Docs: Begin "Start Mode" Documentation (#2301) * set up start mode * note unused modes * fix bss * Player: Name all Start Modes (#2302) * name some start modes * document blue warp mode * Revert "document blue warp mode" This reverts commit d4071a81234b5a8a52635ff4ad8f5a7946cd5660. * name movement modes * fix door mode comment, it is not broken * Player_PutSwordInHand * typo * how the hell did that happen * add sword clarification * Document Hookshot Attachment (#2300) * document hookshot attachment * change comment * swap hookshot function comment * remove comments * Add a PARAMS_PACK macro for building actor params setters (#2304) * Name Remaining Hookshot Actor Flags (#2306) * name remaining hookshot flags * tweak comments * period * Document Actor "Fidget Tables" (#2287) * Document `func_80034F54` and related data new name: `UpdateLimbOverrides` reason: - `0x814` and `0x940` constants - `*_OverrideLimbDraw` functions additionally: - move constants into `z64animation.h` - use these constant for existing formulas - properly name corresponding actors' fields - add occasional explicit limbs limit constants * port over the MM "fidget" naming * remove redundant comments * move and rename `FIDGET_*` constants * introduce a `FIDGET_SCALE` constant, as no other value is applied * remove generally unrelated changes * apply PR suggestion Co-authored-by: mzxrules <[email protected]> * fix (?) fidgetTable size following the zeldaret/oot#2287 (comment) suggestion * remove an unused `struct EnMu` field @ `0x024A` a continuation to the 211263295cd8768d63c1426025cf913ba6bedc18 automatic padding commpensates its absence * remove MM mention as "it would get unruly fast" zeldaret/oot#2287 (comment) * rename `overridePerLimb` -> `fidgetFrequency` zeldaret/oot#2287 (comment) * give better names to the constants zeldaret/oot#2287 (comment) * remove unnecesasry braces from a comment zeldaret/oot#2287 (comment) * make the comment multiline "officially" * restore `limbIndex` naming for this PR zeldaret/oot@43afb7b#r1842644602 * apply a PR suggestion zeldaret/oot#2287 (comment) --------- Co-authored-by: mzxrules <[email protected]> * Player Docs: Document Some Start Mode Actions (#2305) * document blue warp arrive * document warp song, door, and time travel * document grotto and farores wind * move animsfx * review * unname appear * post decomp merge build fixes * format * Document time-specific textures for Deku Tree and Gerudo Fortress similar to other scenes (#2310) * rename time-specific scene file textures * linter fixes * Minor Cleanup (#2308) * cleanup * more * fix floats * Fix some more GCC warnings, mark some bugs based on GCC warnings (#2309) * Fix some more GCC warnings, mark some bugs based on GCC warnings * Weird formatting * Suggested changes * More weird indentation I guess * UNREACHABLE() macro, add missing NORETURNs to fault_n64.c * AVOID_UB for PAL path in z_file_nameset.c * Remove comments about return types * Remove temp no longer needed * Add Hiisuya's New Actor Script (#156) * add actor script * edit readme * changes (-no for now) * Debug Boot (DebugOpeningState) (#136) * First pass of debug boot port * mostly done * general changes, test this comma in commit now * Makefile update: The "," works now * quotes also working now inside a string * get rid of emulator path * format * review * improvements (add skybox and improve print logic) * cleanup and fix build issues * format --------- Co-authored-by: Yanis002 <[email protected]> --------- Co-authored-by: cadmic <[email protected]> Co-authored-by: Dragorn421 <[email protected]> Co-authored-by: Tharo <[email protected]> Co-authored-by: Derek Hensley <[email protected]> Co-authored-by: Anghelo Carvajal <[email protected]> Co-authored-by: Yanis <[email protected]> Co-authored-by: Zeldaboy14 <[email protected]> Co-authored-by: fig02 <[email protected]> Co-authored-by: engineer124 <[email protected]> Co-authored-by: Elliptic Ellipsis <[email protected]> Co-authored-by: engineer124 <[email protected]> Co-authored-by: MNGoldenEagle <[email protected]> Co-authored-by: zelda2774 <[email protected]> Co-authored-by: mzxrules <[email protected]> Co-authored-by: Ozero4 <[email protected]> Co-authored-by: AJ Otto <[email protected]> Co-authored-by: Pepe20129 <[email protected]> Co-authored-by: mracsys <[email protected]> Co-authored-by: Charles Averill <[email protected]> Co-authored-by: Maciek <[email protected]> Co-authored-by: Leonid Kapitonov <[email protected]> Co-authored-by: Recardo <[email protected]> Co-authored-by: Trueffel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a workflow to add building this project to CI, this do NOT upload any build artifacts.
It will build the repo 4 times:
why? we get a lot of feedback from people not being able to build it and everytime I test myself it always works (even from fresh clones), basically the purpose is telling us when we have real build issues, it won't make sure the thing actually boots (obviously)
hopefully works first try (it did on my test branch the other day), this CI build idea was taken from dtk-template