Fix long contexts in LoRA #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanjuCSudhakaran
force-pushed
the
fix-lora-long-contexts
branch
from
9cf911a to
ebcb891
Compare
vivekgoe
requested review from
kzawora-intel,
madamczykhabana,
michalkuligowski and
mgawarkiewicz
as code owners
SanjuCSudhakaran
force-pushed
the
fix-lora-long-contexts
branch
from
ebcb891 to
99c89da
Compare
vivekgoe
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#566 breaks long-contexts + LoRA flow.
This assumes caching sin-cos buffer for first decoder layer is sufficient to handle all cases, which is not the applicable for long-context + LoRA.
This PR ignores
_prepare_cos_sincall prior to HpuModelAdapter forward in long-context + LoRA flow.