fix hpu destructors flow and remove finish_measurements #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 11, 2024
Tiefen-boop
previously approved these changes
Oct 13, 2024
nirda7
force-pushed
the
fix_destructors_flow
branch
from
b2e342c to
ba61352
Compare
nirda7
force-pushed
the
fix_destructors_flow
branch
10 times, most recently
from
9c9d748 to
adbfb47
Compare
nirda7
force-pushed
the
fix_destructors_flow
branch
2 times, most recently
from
a57df85 to
5b1658a
Compare
nirda7
force-pushed
the
fix_destructors_flow
branch
3 times, most recently
from
d539a6c to
6454f3f
Compare
nirda7
dismissed
Tiefen-boop’s stale review
New code - need to review it again
nirda7
requested review from
michalkuligowski,
kzawora-intel,
afierka-intel,
ulivne,
dudilester and
kiazada
nirda7
force-pushed
the
fix_destructors_flow
branch
from
6454f3f to
029f9f9
Compare
nirda7
force-pushed
the
fix_destructors_flow
branch
from
029f9f9 to
592121e
Compare
michalkuligowski
approved these changes
Dec 9, 2024
afierka-intel
pushed a commit
that referenced
this pull request
Dec 11, 2024
Fix hpu related destructors flow, avoiding multiple calls to the same shutdown function. Remove the use of the finish_measurements function.
kzawora-intel
pushed a commit
that referenced
this pull request
Dec 12, 2024
Cherry-pick of existing fix from habana_main. Fix hpu related destructors flow, avoiding multiple calls to the same shutdown function. Remove the use of the finish_measurements function. --------- Co-authored-by: Nir David <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix hpu related destructors flow, avoiding multiple calls to the same shutdown function.
Remove the use of the finish_measurements function.