Add lm_eval test for HPU #298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/hpu/test_hpu_lmeval.py
Outdated
Comment on lines
114
to
115
| [TaskConfigs.gsm8k_llama_cot, TaskConfigs.ifeval], | ||
| ids=['gsm8k_llama_cot', 'ifeval'], |
There was a problem hiding this comment.
I think you can pass a function as 'ids'. Something like:
def get_task_name(task_cfg):
return task_cfg["task_name"]
...
@pytest.mark.parametrize("task_cfg",
[TaskConfigs.gsm8k_llama_cot, TaskConfigs.ifeval],
ids=get_task_name,There was a problem hiding this comment.
Perhaps we should move it to the extension repo?
There was a problem hiding this comment.
Yeah, the PR got a little bloated now. I'll close it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only testing Llama3.1-8b-Instruct with lm_eval on GSM-8K and IFeval. Both tests pass, can be expanded if needed.