Skip to content

Commit

Permalink
changed action lint
Browse files Browse the repository at this point in the history
  • Loading branch information
RonBenMosheHabana committed Dec 18, 2024
1 parent 58a0483 commit 684d784
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .github/actionlint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ self-hosted-runner:
paths:
.github/workflows/**/*.{yml,yaml}:
ignore:
- 'shellcheck reported issue in this script: SC2116:.+'
- 'shellcheck reported issue in this script: SC2086:.+'
- 'shellcheck reported issue in this script: SC2001:.+'
- shellcheck reported issue in this script: SC2116:.+
- shellcheck reported issue in this script: SC2086:.+
- shellcheck reported issue in this script: SC2001:.+
5 changes: 3 additions & 2 deletions .github/workflows/trigger_jenkins.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ jobs:
- name: Create Pod Template
env:
TARGET_BRANCH: ${{ github.base_ref }}
RELEASED_SYNAPSE_VERSION: ${{ vars.RELEASED_SYNAPSE_VERSION }}
RELEASED_SYNAPSE_VERSION: ${{ vars.RELEASED_SYNAPSE_VERSION }}
BASE_BRANCH: ${{github.head_ref}}
run: |

Check failure on line 76 in .github/workflows/trigger_jenkins.yml

View workflow job for this annotation

GitHub Actions / actionlint

shellcheck reported issue in this script: SC2086:info:9:72: Double quote to prevent globbing and word splitting

Check failure on line 76 in .github/workflows/trigger_jenkins.yml

View workflow job for this annotation

GitHub Actions / actionlint

shellcheck reported issue in this script: SC2001:style:12:12: See if you can use ${variable//search/replace} instead
if [[ $TARGET_BRANCH == 'habana_main' ]]; then
synapse_version=${RELEASED_SYNAPSE_VERSION#v}
Expand All @@ -91,7 +92,7 @@ jobs:
sed -i "s/##BUILD##/${synapse_build}/g" pod.yml
sed -i "s/##BUILD_TAG##/${BUILD_TAG}/g" pod.yml
sed -i "s/##PYTORCH_VERSION##/${pt_version}/g" pod.yml
sed -i "s|##GIT_BRANCH##|${{github.head_ref}}|g" pod.yml
sed -i "s|##GIT_BRANCH##|$BASE_BRANCH|g" pod.yml
sed -i "s|##CMD##|$safe_cmd|g" pod.yml
echo "Pod Template Created"
- name: Run Test
Expand Down

0 comments on commit 684d784

Please sign in to comment.