Skip to content

Commit

Permalink
Update workflow to solve linter
Browse files Browse the repository at this point in the history
  • Loading branch information
RonBenMosheHabana committed Jan 9, 2025
1 parent 11bc0d6 commit 5a2c7a0
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/trigger_jenkins.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ jobs:
- name: Calculate Tests
id: tests
run: |

Check failure on line 50 in .github/workflows/trigger_jenkins.yml

View workflow job for this annotation

GitHub Actions / actionlint

shellcheck reported issue in this script: SC2086:info:2:35: Double quote to prevent globbing and word splitting
test_list=$(yq -oj e .jenkins/test_config.yaml | jq '[.stages[].steps[]]')
echo "tests_list=$(echo $test_list)" >> $GITHUB_OUTPUT
test_list=$(yq -oj e .jenkins/test_config.yaml | jq "[.stages[].steps[]]")
echo "tests_list=${test_list}" >> $GITHUB_OUTPUT
TestRun:
name: Test / ${{matrix.tests.name}}
needs: [CalculateJobs]
Expand All @@ -76,18 +76,18 @@ jobs:
RELEASED_SYNAPSE_VERSION: ${{ vars.RELEASED_SYNAPSE_VERSION }}
BASE_BRANCH: ${{github.head_ref}}
run: |

Check failure on line 78 in .github/workflows/trigger_jenkins.yml

View workflow job for this annotation

GitHub Actions / actionlint

shellcheck reported issue in this script: SC2086:info:9:72: Double quote to prevent globbing and word splitting
if [[ $TARGET_BRANCH == 'habana_main' ]]; then
if [[ $TARGET_BRANCH == "habana_main" ]]; then
synapse_version=${RELEASED_SYNAPSE_VERSION#v}
elif [[ $TARGET_BRANCH =~ v*.*.* ]]; then
synapse_version=${TARGET_BRANCH#v}
else
echo "Cant Calculate Synapse Version, Failing The Test"
exit 1
fi
synapse_build=$(curl https://dms.habana-labs.com/api/v1.1/branch/info/v$synapse_version | jq -r '.release_id')
synapse_build=$(curl https://dms.habana-labs.com/api/v1.1/branch/info/v$synapse_version | jq -r ".release_id")
pt_version=${{ vars.PT_VERSION }}
BUILD_TAG="Github-vLLM-Fork-${{ github.event.number }}-${{github.run_number}}"
safe_cmd=$(echo "${TEST_COMMAND}" | sed "s|\\&|\\\\&|g")
safe_cmd=${TEST_COMMAND//&/\\&}
echo "Writing Pod Template To File"
echo "${POD_TEMPLATE}" > pod.yml
sed -i "s/##VERSION##/${synapse_version}/g" pod.yml
Expand Down

0 comments on commit 5a2c7a0

Please sign in to comment.