tbv: Cleanup test_1 to make sure the bit vectors are deleted. #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use different variable names for each sub test - Combine definition and initialization - Localize variables - Make a `request_size` variable to avoid repeating the size of 80000 ``` CID 1546559 (HDFGroup#1-4 of 4): Resource leak (RESOURCE_LEAK) 19. leaked_storage: Variable b going out of scope leaks the storage it points to. ```
schwehr
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
vchoi-hdfgroup
added
Component - Testing
|
As discussed out-of-band, this PR does not match the style the HDF4 team wants, so I'm closing the PR. Feel free to rewrite this fix to the HDF4/HDF5 style if you'd like. Also, this test would be better if it was split into two, either as two test functions or two scopes inside a single test function. That would be a better way of showing that the two checks are supposed to be completely independent. They should not use the same variables to make that independence blatantly obvious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request_sizevariable to avoid repeating the size of 80000